-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear issues list (again) for 2023.9.0 #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also if enabled removes handler_name metadata
Instead select format automatically depending on video format
Will be useful for people who always download video with subtitle
yt-dlp panics if we try to set anything that is not in the list of supported languages, even with ignoreerrors it fails, so here is some complicated stuff to set the language
We save configuration on window close anyway, no need for apply button
The preference should be: |
nlogozzo
requested changes
Sep 11, 2023
nlogozzo
requested changes
Sep 11, 2023
nlogozzo
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No, the option to download only subtitles wasn't added, but instead now there's no format selection, it's chosen by the app to ensure subtitle will be embedded (SRT for MP4 and VTT for WEBM). The state of "Download Subtitle" switch is now also saved to help users who always download video with subtitles.
Two-letter codes with region are now supported. Can be tested with this video and
pt-BR
language code.Also I removed apply button in the entry, it's a bit confusing and doesn't really serve any purpose: we will save configuration on window closing anyway, no need to save it at some other point.
ffprobe
output for the video linked in the issue:This is done by finding current culture's name or two-letter code in a hardcoded list of youtube's supported languages. We have to do this, because giving unsupported language code causes yt-dlp to fail, even with
ignoreerrors
.A switch was added to preferences:
Off by default. I also noticed there was
handler_name
field in streams' metadata containing info about Google in case of youtube videos, so this is now cleared too.