Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear issues list (again) for 2023.9.0 #579

Merged
merged 14 commits into from
Sep 11, 2023
Merged

Clear issues list (again) for 2023.9.0 #579

merged 14 commits into from
Sep 11, 2023

Conversation

fsobolev
Copy link
Member

  • Closes Option to dowload only subtitles ? #568
    No, the option to download only subtitles wasn't added, but instead now there's no format selection, it's chosen by the app to ensure subtitle will be embedded (SRT for MP4 and VTT for WEBM). The state of "Download Subtitle" switch is now also saved to help users who always download video with subtitles.
  • Closes Not all subtitle languages are supported #572
    Two-letter codes with region are now supported. Can be tested with this video and pt-BR language code.
    Also I removed apply button in the entry, it's a bit confusing and doesn't really serve any purpose: we will save configuration on window closing anyway, no need to save it at some other point.
  • Closes Keep original channel name in metadata #574
    ffprobe output for the video linked in the issue:
    Input #0, matroska,webm, from 'Ваш топинамбур.webm':
    Metadata:
      title           : Ваш топинамбур
      ARTIST          : Первый образовательный телеканал
      track           : 0
      DATE            : 20210615
      ENCODER         : Lavf60.3.100
    
    You can see ARTIST is now in Russian.
    This is done by finding current culture's name or two-letter code in a hardcoded list of youtube's supported languages. We have to do this, because giving unsupported language code causes yt-dlp to fail, even with ignoreerrors.
  • Closes Include URL to video in metadata #576
    A switch was added to preferences:
    image
    Off by default. I also noticed there was handler_name field in streams' metadata containing info about Google in case of youtube videos, so this is now cleared too.

Also if enabled removes handler_name metadata
Instead select format automatically depending on video format
Will be useful for people who always download video with subtitle
yt-dlp panics if we try to set anything that is not in the list of supported languages, even with ignoreerrors it fails, so here is some complicated stuff to set the language
We save configuration on window close anyway, no need for apply button
@nlogozzo
Copy link
Member

The preference should be:
Title: Remove Source Data
Description: Clear metadata fields containing the URL and other identifying information of the media source

@fsobolev fsobolev requested review from nlogozzo and removed request for nlogozzo September 10, 2023 23:21
@nlogozzo nlogozzo merged commit d4c26f1 into main Sep 11, 2023
@nlogozzo nlogozzo deleted the 90 branch September 11, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants