Shared - Fix Downloading > 1080p Videos

Fixes #696
NickvisionApps · Dec 24, 2023 · f4b9e21 · f4b9e21
1 parent 612333b
commit f4b9e21
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/NickvisionTubeConverter.GNOME/Program.cs b/NickvisionTubeConverter.GNOME/Program.cs
@@ -45,6 +45,7 @@ public Program(string[] args)
         _mainWindowController = new MainWindowController(args);
         _mainWindowController.AppInfo.Changelog =
             @"* Fixed an issue where split chapters were not renamed correctly
+              * Fixed an issue where videos would not download greater than 1080p resolution
               * Updated translations (Thanks everyone on Weblate!)";
         _application.OnActivate += OnActivate;
         g_signal_connect_data(_application.Handle, "open", _openCallback, IntPtr.Zero, IntPtr.Zero, 0);

diff --git a/NickvisionTubeConverter.Shared/Linux/org.nickvision.tubeconverter.metainfo.xml.in b/NickvisionTubeConverter.Shared/Linux/org.nickvision.tubeconverter.metainfo.xml.in
@@ -46,6 +46,7 @@
     <release version="2023.12.0" date="2023-12-01">
       <description translatable="no">
         <p>- Fixed an issue where split chapters were not renamed correctly</p>
+        <p>- Fixed an issue where videos would not download greater than 1080p resolution</p>
         <p>- Updated translations (Thanks everyone on Weblate!)</p>
       </description>
     </release>

diff --git a/NickvisionTubeConverter.Shared/Models/Download.cs b/NickvisionTubeConverter.Shared/Models/Download.cs
@@ -276,7 +276,7 @@ public void Start(DownloadOptions options)
                         _ => ""
                     };
                     var proto = _advancedOptions.Timeframe != null ? "[protocol!*=m3u8]" : "";
-                    var vcodec = _advancedOptions.PreferAV1 ? "[vcodec=vp9.2]" : "[vcodec!*=vp]";
+                    var vcodec = (_advancedOptions.PreferAV1 || Resolution! > new VideoResolution(1920, 1080)) ? "[vcodec=vp9.2]" : "[vcodec!*=vp]";
                     var resolution = Resolution! == VideoResolution.Best ? "" : $"[width<={Resolution!.Width}][height<={Resolution!.Height}]";
                     var formats = new HashSet<string>() //using a HashSet ensures no duplicates, for example if ext == ""
                     {

diff --git a/NickvisionTubeConverter.WinUI/App.xaml.cs b/NickvisionTubeConverter.WinUI/App.xaml.cs
@@ -23,6 +23,7 @@ public App()
         InitializeComponent();
         _controller = new MainWindowController(Array.Empty<string>());
         _controller.AppInfo.Changelog = @"- Fixed an issue where split chapters were not renamed correctly
+- Fixed an issue where videos would not download greater than 1080p resolution
 - Redesigned the app's UI
 - Updated translations (Thanks everyone on Weblate!)";
         if (_controller.Theme != Theme.System)