feat: eth protos #366

cgilbe27 · 2024-07-29T13:33:29Z

Adds ETH protos
Adds 99% coverage for what the backend on testnet-1 exposes
Removes deprecated GQL

Combines all extensions into a single typed extension

StargateQueryClient.withExtensions can only handle 19 total extensions

Moves stableswap and balancer code to utils

Summary by CodeRabbit

New Features
- Introduced new interfaces and functions for Ethereum-related messaging and queries, enhancing SDK capabilities.
- Improved accessibility by restructuring existing interfaces for direct method exposure.
Bug Fixes
- Updated subproject commit identifier, potentially addressing past issues.
Refactor
- Simplified access patterns by removing unnecessary nested objects and restructuring exports for better clarity and maintainability.
Tests
- Added unit tests for Ethereum messaging functionalities, and updated existing tests to align with the new structure, improving readability and ease of maintenance.

coderabbitai · 2024-07-29T13:33:36Z

Walkthrough

This pull request enhances the SDK by simplifying interfaces, refining module exports, and integrating new Ethereum functionalities. It streamlines access patterns, removes deprecated features, and updates tests for better clarity. Collectively, these changes improve usability and maintainability, laying a strong foundation for future development and integration.

Changes

File(s)	Change Summary
`src/sdk/index.ts`, `src/sdk/msg/index.ts`, `src/sdk/query/index.ts`	Updated exports: removed `stableswap`, added `eth` modules.
`src/sdk/msg/devgas.ts`, `src/sdk/query/inflation.ts`, `src/sdk/query/oracle.ts`, `src/sdk/msg/sudo.ts`, `src/sdk/query/tokenfactory.ts`	Flattened interfaces for direct method access, improving usability.
`src/sdk/msg/eth.ts`, `src/sdk/query/eth.ts`, `src/sdk/query/query.ts`	Introduced new interfaces and functions for Ethereum messaging and queries, enhancing capabilities.
Various test files	Refactored tests to align with new structure, improving access patterns and clarity.
`src/gql/heart-monitor/heart-monitor.ts`	Removed methods related to `markPriceCandles` and `perp`, added properties for `gqlEndpt` and subscriptions.
`.github/workflows/release.yaml`, `.github/workflows/test-ts-sdk.yaml`	Added `BUF_TOKEN` environment variable to workflows for enhanced API interactions.

Poem

🐰 In the meadow of code, changes abound,
Interfaces dance, new paths to be found.
With each little tweak, the SDK sings,
A simpler structure, oh, what joy it brings!
Let us hop and rejoice, for clarity's here,
In the world of development, we cheer, we cheer! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-29T14:18:50Z

Lines	Statements	Branches	Functions
	97.23% (913/939)	93.52% (231/247)	95.56% (302/316)

coderabbitai

Actionable comments posted: 3

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d23c144 and b40ff85.

Files ignored due to path filters (1)

src/sdk/utils/mocks/stabletests.csv is excluded by !**/*.csv

Files selected for processing (27)

nibiru (1 hunks)
src/sdk/index.ts (1 hunks)
src/sdk/msg/devgas.ts (2 hunks)
src/sdk/msg/eth.ts (1 hunks)
src/sdk/msg/index.ts (1 hunks)
src/sdk/msg/inflation.ts (2 hunks)
src/sdk/msg/oracle.ts (2 hunks)
src/sdk/msg/sudo.ts (1 hunks)
src/sdk/msg/tokenfactory.ts (2 hunks)
src/sdk/query/devgas.ts (1 hunks)
src/sdk/query/epochs.test.ts (3 hunks)
src/sdk/query/epochs.ts (1 hunks)
src/sdk/query/eth.ts (1 hunks)
src/sdk/query/index.ts (1 hunks)
src/sdk/query/inflation.test.ts (7 hunks)
src/sdk/query/inflation.ts (2 hunks)
src/sdk/query/oracle.test.ts (12 hunks)
src/sdk/query/oracle.ts (2 hunks)
src/sdk/query/query.test.ts (3 hunks)
src/sdk/query/query.ts (3 hunks)
src/sdk/query/sudo.test.ts (2 hunks)
src/sdk/query/sudo.ts (1 hunks)
src/sdk/query/tokenfactory.ts (2 hunks)
src/sdk/tx/txClient.ts (2 hunks)
src/sdk/utils/balancer.test.ts (1 hunks)
src/sdk/utils/index.ts (1 hunks)
src/sdk/utils/stableswap.test.ts (1 hunks)

Files skipped from review due to trivial changes (6)

nibiru
src/sdk/msg/tokenfactory.ts
src/sdk/query/oracle.ts
src/sdk/utils/balancer.test.ts
src/sdk/utils/index.ts
src/sdk/utils/stableswap.test.ts

Additional comments not posted (56)

src/sdk/index.ts (1)

Line range hint 1-7:
Verify the impact of removing the stableswap export.

The removal of the stableswap export might affect any dependent code that relied on this module. Ensure that the functionalities provided by stableswap are either deprecated or moved to another module.
src/sdk/msg/index.ts (1)
6-6: LGTM! But verify the impact of the new eth export.

The addition of the eth export enhances the module's functionality by making the contents of the eth module available. Ensure that the new export does not introduce any conflicts or issues.

Verification successful

The new eth export does not introduce any conflicts.

The addition of the eth export in src/sdk/msg/index.ts is consistent with other parts of the codebase and does not introduce any conflicts or issues.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify if the new `eth` export introduces any conflicts.

# Test: Search for the usage of `eth` in the codebase. Expect: No conflicts or issues.
rg --type python -A 5 $'eth'
Length of output: 58

Script:
#!/bin/bash
# Description: Verify if the new `eth` export introduces any conflicts.

# Test: Search for the usage of `eth` in the TypeScript and JavaScript files in the codebase. Expect: No conflicts or issues.
rg --type ts --type js -A 5 eth
Length of output: 8444
src/sdk/query/index.ts (1)
7-7: LGTM! But verify the impact of the new eth export.

The addition of the eth export enhances the module's functionality by making the contents of the eth module available. Ensure that the new export does not introduce any conflicts or issues.

Verification successful

LGTM! The new eth export does not introduce any conflicts.

The addition of the eth export enhances the module's functionality by making the contents of the eth module available. The search results indicate that the eth module is used extensively within the codebase, and the new export statement is consistent with existing patterns.

src/sdk/query/eth.ts: Contains the definitions and implementations related to the eth module.

src/sdk/query/index.ts: The new export statement aligns with other exports in the file.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify if the new `eth` export introduces any conflicts.

# Test: Search for the usage of `eth` in the codebase. Expect: No conflicts or issues.
rg --type python -A 5 $'eth'
Length of output: 58

Script:
#!/bin/bash
# Description: Verify if the new `eth` export introduces any conflicts.

# Test: Search for the usage of `eth` in the codebase. Expect: No conflicts or issues.
rg --type typescript -A 5 eth
Length of output: 66

Script:
#!/bin/bash
# Description: Verify if the new `eth` export introduces any conflicts.

# Test: Search for the usage of `eth` in the codebase. Expect: No conflicts or issues.
rg --type ts -A 5 eth
Length of output: 8028
src/sdk/query/sudo.ts (2)

9-9: LGTM! Interface update simplifies usage.

The SudoExtension interface update promotes querySudoers to a direct property, improving clarity and usability.

16-17: LGTM! Function update simplifies return structure.

The setupSudoExtension function update returns querySudoers directly, reducing complexity and enhancing usability.

src/sdk/msg/sudo.ts (2)

11-12: LGTM! Interface update simplifies usage.

The SudoMsgExtension interface update promotes editSudoers and changeRoot to direct properties, improving clarity and usability.

19-23: LGTM! Function update simplifies return structure.

The setupSudoMsgExtension function update returns editSudoers and changeRoot directly, reducing complexity and enhancing usability.

src/sdk/query/epochs.ts (2)

11-14: LGTM! Interface update simplifies usage.

The EpochsExtension interface update promotes currentEpoch and epochsInfos to direct properties, improving clarity and usability.

21-25: LGTM! Function update simplifies return structure.

The setupEpochsExtension function update returns currentEpoch and epochsInfos directly, reducing complexity and enhancing usability.

src/sdk/msg/eth.ts (2)

1-8: Imports look good!

The necessary modules for protobuf and query client are imported correctly.

10-13: Interface definition is clear and concise.

The EthMsgExtension interface defines two methods for Ethereum transactions and parameter updates.

src/sdk/msg/inflation.ts (2)

Line range hint 1-10:
Imports look good!

The necessary modules for protobuf and query client are imported correctly.

11-16: Interface definition is clear and concise.

The InflationMsgExtension interface now directly exposes the methods for toggling inflation and editing inflation parameters.

src/sdk/query/tokenfactory.ts (2)

Line range hint 1-10:
Imports look good!

The necessary modules for protobuf and query client are imported correctly.

13-15: Interface definition is clear and concise.

The TokenFactoryExtension interface now directly exposes the methods for querying denomination info, denominations, and parameters.
src/sdk/query/sudo.test.ts (2)
28-28: LGTM!

The code changes are approved.

17-18: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to querySudoers match the new structure.

Verification successful

Verified: The function querySudoers is used correctly in the new structure.

The function querySudoers is defined and utilized appropriately in the TypeScript files:

src/sdk/query/sudo.ts

src/sdk/query/sudo.test.ts
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify all function calls to `querySudoers` match the new structure.

# Test: Search for the function usage. Expect: Only occurrences of the new structure.
rg --type python -A 5 $'querySudoers'
Length of output: 67

Script:
#!/bin/bash
# Description: Verify all function calls to `querySudoers` match the new structure.

# Test: Search for the function usage. Expect: Only occurrences of the new structure.
rg --type typescript -A 5 'querySudoers'
Length of output: 75

Script:
#!/bin/bash
# Description: Verify all function calls to `querySudoers` match the new structure.

# Test: Search for the function usage. Expect: Only occurrences of the new structure.
rg --type ts -A 5 'querySudoers'
rg --type js -A 5 'querySudoers'
Length of output: 1672
src/sdk/msg/devgas.ts (2)

15-24: LGTM!

The code changes are approved.

33-43: LGTM!

The code changes are approved.

src/sdk/query/devgas.ts (2)

15-20: LGTM!

The code changes are approved.

27-39: LGTM!

The code changes are approved.

src/sdk/query/inflation.ts (2)

19-24: LGTM! Simplified interface.

The InflationExtension interface is now more straightforward with methods directly declared as properties. This improves usability and readability.

33-51: LGTM! Simplified object structure.

The setupInflationExtension function now returns methods directly, simplifying the structure of the returned object. This makes the methods more accessible.

src/sdk/msg/oracle.ts (2)

15-26: LGTM! Simplified interface.

The OracleMsgExtension interface is now more straightforward with methods directly declared as properties. This improves usability and readability.

35-53: LGTM! Simplified object structure.

The setupOracleMsgExtension function now returns methods directly, simplifying the structure of the returned object. This makes the methods more accessible.

src/sdk/query/epochs.test.ts (3)

20-22: LGTM! Simplified access pattern.

The extension object is now directly referenced without the nested epochs property. This simplifies the access pattern and improves code clarity.

32-34: LGTM! Simplified method invocation.

The currentEpoch method is now directly referenced without the nested epochs property. This simplifies the invocation of the method, enhancing readability.

49-51: LGTM! Simplified method invocation.

The epochsInfos method is now directly referenced without the nested epochs property. This simplifies the invocation of the method, enhancing readability.

src/sdk/tx/txClient.ts (2)

20-20: LGTM! Import statements refactored correctly.

The import statements have been consolidated to streamline the extension setup process.

46-46: LGTM! Constructor method updated correctly.

The constructor method has been updated to use setupNibiruExtension, streamlining the initialization process.

src/sdk/query/eth.ts (2)

29-46: LGTM! Interface EthExtension defined correctly.

The EthExtension interface defines various Ethereum-related query methods, which are relevant and correctly defined.

48-89: LGTM! Setup function setupEthExtension implemented correctly.

The setupEthExtension function correctly initializes the QueryClientImpl and defines the Ethereum-related query methods.

src/sdk/query/inflation.test.ts (7)

30-36: LGTM! Test cases updated correctly.

The test cases have been updated to simplify property access, improving readability and maintainability.

46-46: LGTM! Test case for period method updated correctly.

The test case for the period method has been updated to reflect the changes made to the setupInflationExtension function.

60-60: LGTM! Test case for epochMintProvision method updated correctly.

The test case for the epochMintProvision method has been updated to reflect the changes made to the setupInflationExtension function.

76-76: LGTM! Test case for skippedEpochs method updated correctly.

The test case for the skippedEpochs method has been updated to reflect the changes made to the setupInflationExtension function.

90-90: LGTM! Test case for circulatingSupply method updated correctly.

The test case for the circulatingSupply method has been updated to reflect the changes made to the setupInflationExtension function.

104-104: LGTM! Test case for inflationRate method updated correctly.

The test case for the inflationRate method has been updated to reflect the changes made to the setupInflationExtension function.

118-118: LGTM! Test case for params method updated correctly.

The test case for the params method has been updated to reflect the changes made to the setupInflationExtension function.
src/sdk/query/query.ts (7)
15-15: Import statement approved.

The inclusion of QueryClient is necessary for the new extension setup.

56-74: New interface NibiruExtension approved.

The interface consolidates various message and query extensions, improving modularity and organization.

105-105: Updated type NibiruExtensions approved.

The type definition now includes the new NibiruExtension, simplifying the overall structure.

144-144: Changes to NibiruQuerier class approved.

The class now uses setupNibiruExtension, enhancing maintainability and readability.

Line range hint 195-195:
No changes detected in getTxByHash method.

Skipping review for this segment.

Line range hint 207-207:
No changes detected in getTxByHashBytes method.

Skipping review for this segment.

76-96: Function setupNibiruExtension approved.

The function is well-structured and ensures proper initialization of all extensions.

However, ensure that the function is correctly used throughout the codebase.

Verification successful

Function setupNibiruExtension usage verified.

The function is correctly used in the following files:

src/sdk/tx/txClient.ts

src/sdk/query/query.ts
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the usage of `setupNibiruExtension` in the codebase.

# Test: Search for the function usage. Expect: Correct usage throughout the codebase.
rg --type js -A 5 $'setupNibiruExtension'
Length of output: 40

Script:
#!/bin/bash
# Description: Verify the usage of `setupNibiruExtension` in the codebase.

# Test: Search for the function usage across all file types. Expect: Correct usage throughout the codebase.
rg -A 5 'setupNibiruExtension'
Length of output: 1239
src/sdk/query/oracle.test.ts (3)

60-71: Refactor of setupOracleExtension tests approved.

The refactor enhances code clarity by reducing nesting levels while maintaining functional behavior.

97-97: Test oracle.actives changes approved.

The changes simplify the test code while maintaining functional behavior.

111-111: Test oracle.aggregatePrevote changes approved.

The changes simplify the test code while maintaining functional behavior.

src/sdk/query/query.test.ts (7)

55-55: Test query active oracles changes approved.

The changes reference the query module for oracle methods, indicating a restructuring of the query handling.

65-65: Test query oracle params changes approved.

The changes reference the query module for oracle methods, indicating a restructuring of the query handling.

72-73: Test query exchange rates changes approved.

The changes reference the query module for oracle methods, indicating a restructuring of the query handling.

91-91: Test query epochs info and current epoch changes approved.

The changes reference the query module for epochs methods, indicating a restructuring of the query handling.

Line range hint 108-108:
No changes detected in x/staking module queries section.

Skipping review for this segment.

Line range hint 124-124:
No changes detected in distribution module queries section.

Skipping review for this segment.

Line range hint 143-143:
No changes detected in gov module queries section.

Skipping review for this segment.

src/sdk/msg/eth.ts

src/sdk/msg/inflation.ts

src/sdk/query/tokenfactory.ts

cgilbe27 · 2024-07-30T15:00:20Z

Tests

coderabbitai

Actionable comments posted: 6

Outside diff range, codebase verification and nitpick comments (15)

src/gql/query/index.ts (1)
Re-add the perp export to avoid breaking existing functionality.

The perp module is still being referenced in multiple files, indicating its functionality is still in use. Removing this export without addressing these references will likely break the existing functionality.

src/gql/query/index.ts: Re-add the export for perp.

Analysis chain

Line range hint 1-14:
Verify the impact of removing the perp export.

The removal of this export suggests that the functionality related to perp is either deprecated or moved. Ensure that this change does not break any existing functionality.

Let's check if the perp module is defined elsewhere in the codebase to understand its current state and verify if the removal of the export is valid.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the impact of removing the `perp` export.

# Test: Search for the usage of `perp`. Expect: No occurrences of the old export.
rg --type ts -A 5 $'perp'
Length of output: 5684

Script:
#!/bin/bash
# Description: Check if the `perp` module is defined elsewhere in the codebase.

# Search for the definition of `perp` to understand its current state.
rg --type ts -A 5 'perp'
Length of output: 5684
src/sdk/msg/sudo.test.ts (1)
1-3: Add a description for the imports.

Adding a brief description for the imported modules and functions will improve readability and maintainability.
+ // Import necessary modules and functions for testing
import { QueryClient } from "@cosmjs/stargate"
import * as query from "../../protojs/nibiru/sudo/v1/tx"
import { setupSudoMsgExtension } from "."
src/sdk/query/tokenfactory.test.ts (1)
14-21: Consider adding more specific assertions.

The test case verifies that the extension is set up correctly, but it could be improved by adding assertions to check the properties of the extension.
+    expect(extension.denomInfo).toBeDefined()
+    expect(extension.denoms).toBeDefined()
+    expect(extension.params).toBeDefined()
src/sdk/msg/eth.test.ts (1)
16-22: Consider adding more specific assertions.

The test case verifies that the extension is set up correctly, but it could be improved by adding assertions to check the properties of the extension.
+    expect(extension.ethereumTx).toBeDefined()
+    expect(extension.updateParams).toBeDefined()
src/sdk/msg/inflation.test.ts (1)
15-21: Consider adding more specific assertions.

The test case verifies that the extension is set up correctly, but it could be improved by adding assertions to check the properties of the extension.
+    expect(extension.toggleInflation).toBeDefined()
+    expect(extension.editInflationParams).toBeDefined()
src/gql/query/stats.ts (7)
Line range hint 53-59: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.fees) {
+  if (fields?.fees) {
Line range hint 64-70: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.perpOpenInterest) {
+  if (fields?.perpOpenInterest) {
Line range hint 75-81: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.perpPnl) {
+  if (fields?.perpPnl) {
Line range hint 86-92: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.totals) {
+  if (fields?.totals) {
Line range hint 97-103: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.tvl) {
+  if (fields?.tvl) {
Line range hint 108-114: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.users) {
+  if (fields?.users) {
Line range hint 119-125: Potential runtime error due to direct property access.

The removal of optional chaining assumes that fields is always defined. This could lead to runtime errors if fields is undefined.
-  if (fields.volume) {
+  if (fields?.volume) {
QUERIES.md (2)
Line range hint 1-1:
Update the table of contents.

The table of contents still references the removed markPriceCandles and markPrices queries.
-  - [markPriceCandles](#markpricecandles)
-    - [`order: MarkPriceCandlesOrder`](#order-markpricecandlesorder)
-  - [markPrices](#markprices)
Line range hint 1-1:
Add documentation for remaining queries.

Several queries have TODO placeholders for documentation. Ensure that documentation is added for all queries.

Do you want me to help generate the documentation for the remaining queries or open a GitHub issue to track this task?
src/gql/heart-monitor/heart-monitor.test.ts (1)
457-457: Flag: Skipped test.

The staking test has been skipped. Add a TODO comment explaining why it is skipped and when it should be re-enabled.
- test.skip("staking", async () => {
+ // TODO: Explain why this test is skipped and when it should be re-enabled.
+ test.skip("staking", async () => {

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b40ff85 and cf2b865.

Files selected for processing (28)

QUERIES.md (1 hunks)
src/gql/heart-monitor/heart-monitor.test.ts (12 hunks)
src/gql/heart-monitor/heart-monitor.ts (7 hunks)
src/gql/query/governance.ts (3 hunks)
src/gql/query/ibc.ts (2 hunks)
src/gql/query/index.ts (1 hunks)
src/gql/query/inflation.ts (3 hunks)
src/gql/query/oracle.ts (2 hunks)
src/gql/query/staking.ts (6 hunks)
src/gql/query/stats.ts (7 hunks)
src/gql/query/wasm.ts (1 hunks)
src/gql/subscription/index.ts (1 hunks)
src/gql/utils/consts.test.ts (2 hunks)
src/sdk/msg/devgas.test.ts (1 hunks)
src/sdk/msg/eth.test.ts (1 hunks)
src/sdk/msg/inflation.test.ts (1 hunks)
src/sdk/msg/oracle.test.ts (1 hunks)
src/sdk/msg/sudo.test.ts (1 hunks)
src/sdk/msg/tokenfactory.test.ts (1 hunks)
src/sdk/query/devgas.test.ts (1 hunks)
src/sdk/query/epochs.test.ts (3 hunks)
src/sdk/query/eth.test.ts (1 hunks)
src/sdk/query/inflation.test.ts (7 hunks)
src/sdk/query/oracle.test.ts (14 hunks)
src/sdk/query/query.test.ts (6 hunks)
src/sdk/query/tokenfactory.test.ts (1 hunks)
src/sdk/query/tokenfactory.ts (2 hunks)
src/sdk/utils/math.test.ts (1 hunks)

Files skipped from review due to trivial changes (1)

src/gql/subscription/index.ts

Files skipped from review as they are similar to previous changes (5)

src/sdk/query/epochs.test.ts
src/sdk/query/inflation.test.ts
src/sdk/query/oracle.test.ts
src/sdk/query/query.test.ts
src/sdk/query/tokenfactory.ts

Additional comments not posted (80)

src/gql/query/index.ts (7)
Line range hint 1-14:
Verify the impact of removing the spotPoolSwap export.

The removal of this export suggests that the functionality related to spotPoolSwap is either deprecated or moved. Ensure that this change does not break any existing functionality.

Verification successful

The removal of the spotPoolSwap export does not impact existing functionality.

The spotPoolSwap module or export is not found anywhere in the codebase, suggesting it has been deprecated or removed entirely.

No occurrences of spotPoolSwap were found in the TypeScript files.

No file named spotPoolSwap.ts exists in the codebase.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotPoolSwap` export.

# Test: Search for the usage of `spotPoolSwap`. Expect: No occurrences of the old export.
rg --type ts -A 5 $'spotPoolSwap'
Length of output: 32

Script:
#!/bin/bash
# Search for the definition of `spotPoolSwap` to understand where it is declared.
rg 'spotPoolSwap' --type ts -A 5

# Check if the `spotPoolSwap` module file exists in the codebase.
fd 'spotPoolSwap.ts'
Length of output: 53
Line range hint 1-14:
Verify the impact of removing the spotPools export.

The removal of this export suggests that the functionality related to spotPools is either deprecated or moved. Ensure that this change does not break any existing functionality.

Line range hint 1-14:
Verify the impact of removing the spotPoolExited export.

The removal of this export suggests that the functionality related to spotPoolExited is either deprecated or moved. Ensure that this change does not break any existing functionality.

Verification successful

No issues found with the removal of the spotPoolExited export.

The spotPoolExited export is not defined or used anywhere in the codebase, indicating that its removal does not impact any existing functionality.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotPoolExited` export.

# Test: Search for the usage of `spotPoolExited`. Expect: No occurrences of the old export.
rg --type ts -A 5 $'spotPoolExited'
Length of output: 34

Script:
#!/bin/bash
# Description: Search for the definition of `spotPoolExited` in the codebase.

# Test: Find the definition of `spotPoolExited`. Expect: To find where it was originally defined.
rg --type ts -A 5 'spotPoolExited'
Length of output: 34

Script:
#!/bin/bash
# Description: Search for mentions of `spotPoolExited` in the entire codebase, including documentation files.

# Test: Find any mentions of `spotPoolExited`. Expect: To find references in any type of file.
rg 'spotPoolExited'
Length of output: 19
Line range hint 1-14:
Verify the impact of removing the spotLpPositions export.

The removal of this export suggests that the functionality related to spotLpPositions is either deprecated or moved. Ensure that this change does not break any existing functionality.

Verification successful

The removal of the spotLpPositions export does not impact any existing functionality.

The term spotLpPositions was not found in the TypeScript files, comments, or documentation, indicating that it is not used anywhere in the codebase.

No occurrences of spotLpPositions were found in the codebase.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotLpPositions` export.

# Test: Search for the usage of `spotLpPositions`. Expect: No occurrences of the old export.
rg --type ts -A 5 $'spotLpPositions'
Length of output: 35

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotLpPositions` export.

# Test: Search for the usage of `spotLpPositions` across all file types.
rg -A 5 'spotLpPositions'
Length of output: 25

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotLpPositions` export.

# Test: Search for the usage of `spotLpPositions` in comments and documentation files.
rg -A 5 'spotLpPositions' --glob '*.md' --glob '*.txt' --glob '*.mdx' --glob '*.js' --glob '*.ts'
Length of output: 97
Line range hint 1-14:
Verify the impact of removing the spotPoolJoined export.

The removal of this export suggests that the functionality related to spotPoolJoined is either deprecated or moved. Ensure that this change does not break any existing functionality.

Verification successful

The removal of spotPoolJoined export has been verified.

The spotPoolJoined and related functionalities have been removed across multiple files, including test files and main implementation files. This suggests a deliberate refactor or deprecation. No critical dependencies or functionalities appear to be broken due to this removal.

Commit efc002389514e69189fd7ff1b2cf739bc7384b66 shows the removal of spotPoolJoined and related functionalities.

No usages of spotPoolJoined were found in the codebase.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotPoolJoined` export.

# Test: Search for the usage of `spotPoolJoined`. Expect: No occurrences of the old export.
rg --type ts -A 5 $'spotPoolJoined'
Length of output: 34

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotPoolJoined` export.

# Test 1: Search for the usage of `spotPoolJoined` in all file types.
rg -A 5 'spotPoolJoined'

# Test 2: Check the repository history for recent changes related to `spotPoolJoined`.
git log -p -S 'spotPoolJoined'
Length of output: 64661
Line range hint 1-14:
Verify the impact of removing the markPriceCandles export.

The removal of this export suggests that the functionality related to markPriceCandles is either deprecated or moved. Ensure that this change does not break any existing functionality.

Line range hint 1-14:
Verify the impact of removing the spotPoolCreated export.

The removal of this export suggests that the functionality related to spotPoolCreated is either deprecated or moved. Ensure that this change does not break any existing functionality.

Verification successful

To ensure comprehensive verification, let's search for any files or modules that might be related to spotPoolCreated to confirm whether it has been deprecated or moved.

Let's correct the file type specification in the rg command and re-run the search to ensure thorough verification.

Let's correct the file type specification once more and re-run the search, ensuring only valid file types are used.

Let's correct the file type specification once more and re-run the search, ensuring only valid file types are used.

No issues found with the removal of the spotPoolCreated export.

The search did not find any occurrences or related files for spotPoolCreated, suggesting that its removal does not impact existing functionality.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the impact of removing the `spotPoolCreated` export.

# Test: Search for the usage of `spotPoolCreated`. Expect: No occurrences of the old export.
rg --type ts -A 5 $'spotPoolCreated'
Length of output: 35

Script:
#!/bin/bash
# Description: Search for any files or modules related to `spotPoolCreated`.

# Find files that might be related to `spotPoolCreated`.
fd -e ts -e tsx -e js -e jsx -e json -e graphql -e gql 'spotPoolCreated'

# Search for any comments or references to `spotPoolCreated`.
rg 'spotPoolCreated' --type ts --type tsx --type js --type jsx --type json --type graphql --type gql
Length of output: 201

Script:
#!/bin/bash
# Description: Search for any files or modules related to `spotPoolCreated`.

# Find files that might be related to `spotPoolCreated`.
fd -e ts -e tsx -e js -e jsx -e json -e graphql -e gql 'spotPoolCreated'

# Search for any comments or references to `spotPoolCreated`.
rg 'spotPoolCreated' --type ts --type js --type jsx --type json --type graphql --type gql
Length of output: 190

Script:
#!/bin/bash
# Description: Search for any files or modules related to `spotPoolCreated`.

# Find files that might be related to `spotPoolCreated`.
fd -e ts -e tsx -e js -e json -e graphql -e gql 'spotPoolCreated'

# Search for any comments or references to `spotPoolCreated`.
rg 'spotPoolCreated' --type ts --type js --type json --type graphql --type gql
Length of output: 176

Script:
#!/bin/bash
# Description: Search for any files or modules related to `spotPoolCreated`.

# Find files that might be related to `spotPoolCreated`.
fd -e ts -e tsx -e js -e json -e gql 'spotPoolCreated'

# Search for any comments or references to `spotPoolCreated`.
rg 'spotPoolCreated' --type ts --type js --type json
Length of output: 107
src/gql/query/oracle.ts (3)

44-44: Verify the existence of fields.

The removal of optional chaining assumes that fields is always defined. Ensure that fields is always a valid object to avoid runtime errors.

Line range hint 48-48:
LGTM! But ensure oracleQueryString is verified.

The code changes are approved.

33-33: Verify the existence of fields.

The removal of optional chaining assumes that fields is always defined. Ensure that fields is always a valid object to avoid runtime errors.

src/gql/utils/consts.test.ts (2)

52-57: LGTM!

The test case for the arg function with an object argument is well-written and ensures correct output formatting.

59-62: LGTM!

The test case for the objToGql function with an incorrect object type is well-written and ensures the function handles unexpected types gracefully.

src/gql/query/inflation.ts (4)

46-46: Verify the existence of fields.

The removal of optional chaining assumes that fields is always defined. Ensure that fields is always a valid object to avoid runtime errors.

57-57: Verify the existence of fields.

The removal of optional chaining assumes that fields is always defined. Ensure that fields is always a valid object to avoid runtime errors.

Line range hint 63-63:
LGTM! But ensure inflationQueryString is verified.

The code changes are approved.

35-35: Verify the existence of fields.

The removal of optional chaining assumes that fields is always defined. Ensure that fields is always a valid object to avoid runtime errors.

src/gql/query/governance.ts (3)

48-48: Ensure fields is always defined.

Removing optional chaining makes the code stricter, but it assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

59-59: Ensure fields is always defined.

Removing optional chaining makes the code stricter, but it assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

37-37: Ensure fields is always defined.

Removing optional chaining makes the code stricter, but it assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

src/sdk/msg/sudo.test.ts (3)

15-21: Test case looks good!

The test case for setupSudoMsgExtension is well-written and covers the basic functionality.

23-41: Test case looks good!

The test case for editSudoers is well-written and covers the basic functionality.

44-61: Test case looks good!

The test case for changeRoot is well-written and covers the basic functionality.

src/gql/query/staking.ts (7)

45-45: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

56-56: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

67-67: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

78-78: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

89-89: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

110-110: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

41-41: Ensure fields is always defined.

Making the fields parameter required and removing optional chaining assumes that fields is always defined. Ensure that fields is never undefined or null to avoid runtime errors.

src/sdk/query/tokenfactory.test.ts (3)

23-34: LGTM!

The test case is well-structured and verifies the behavior of the denomInfo method.

37-47: LGTM!

The test case is well-structured and verifies the behavior of the denoms method.

49-59: LGTM!

The test case is well-structured and verifies the behavior of the params method.

src/sdk/msg/eth.test.ts (2)

24-44: LGTM!

The test case is well-structured and verifies the behavior of the ethereumTx method.

47-79: LGTM!

The test case is well-structured and verifies the behavior of the updateParams method.

src/sdk/msg/inflation.test.ts (2)

23-39: LGTM!

The test case is well-structured and verifies the behavior of the toggleInflation method.

42-76: LGTM!

The test case is well-structured and verifies the behavior of the editInflationParams method.

src/sdk/utils/math.test.ts (1)

77-101: LGTM!

The new test case is well-constructed and covers an important edge case.

src/sdk/query/devgas.test.ts (5)

17-25: LGTM!

The test case verifies the correct setup of the extension.

27-39: LGTM!

The test case verifies the correct behavior of the feeShare method.

42-56: LGTM!

The test case verifies the correct behavior of the feeSharesByWithdrawer method.

59-73: LGTM!

The test case verifies the correct behavior of the feeShares method.

76-86: LGTM!

The test case verifies the correct behavior of the params method.

src/sdk/msg/devgas.test.ts (5)

21-29: LGTM!

The test ensures that the extension is set up correctly and verifies the existence of the expected functions.

31-49: LGTM!

The test ensures that MsgRegisterFeeShare is called with the correct parameters and the response is as expected.

52-70: LGTM!

The test ensures that MsgUpdateFeeShare is called with the correct parameters and the response is as expected.

73-89: LGTM!

The test ensures that MsgCancelFeeShare is called with the correct parameters and the response is as expected.

92-116: LGTM!

The test ensures that MsgUpdateParams is called with the correct parameters and the response is as expected.

src/sdk/msg/oracle.test.ts (5)

21-29: LGTM!

The test ensures that the extension is set up correctly and verifies the existence of the expected functions.

31-49: LGTM!

The test ensures that MsgAggregateExchangeRatePrevote is called with the correct parameters and the response is as expected.

52-72: LGTM!

The test ensures that MsgAggregateExchangeRateVote is called with the correct parameters and the response is as expected.

75-91: LGTM!

The test ensures that MsgDelegateFeedConsent is called with the correct parameters and the response is as expected.

94-128: LGTM!

The test ensures that MsgEditOracleParams is called with the correct parameters and the response is as expected.

src/gql/heart-monitor/heart-monitor.ts (3)

64-66: Added properties to IHeartMonitor.

The properties gqlEndpt, defaultGqlEndpt, and subscriptionClient have been added to the IHeartMonitor interface. These additions enhance the configuration and management of GraphQL subscriptions.

118-118: Enforced fields parameter in staking method.

The staking method now requires the fields parameter, enforcing stricter usage.

213-213: Enforced fields parameter in staking method.

The staking method now requires the fields parameter, enforcing stricter usage.

src/sdk/msg/tokenfactory.test.ts (9)

1-5: Import statements.

The import statements correctly include necessary modules and dependencies.

6-42: Test setup for setupTokenFactoryMsgExtension.

The test setup correctly mocks the MsgClientImpl and verifies the extension setup.

44-61: Test case for createDenom method.

The test case correctly verifies the createDenom method.

63-82: Test case for changeAdmin method.

The test case correctly verifies the changeAdmin method.

84-105: Test case for updateModuleParams method.

The test case correctly verifies the updateModuleParams method.

107-126: Test case for mint method.

The test case correctly verifies the mint method.

128-147: Test case for burn method.

The test case correctly verifies the burn method.

149-184: Test case for setDenomMetadata method.

The test case correctly verifies the setDenomMetadata method.

186-203: Test case for burnNative method.

The test case correctly verifies the burnNative method.

src/sdk/query/eth.test.ts (14)

1-6: Import statements.

The import statements correctly include necessary modules and dependencies.

7-63: Test setup for setupEthExtension.

The test setup correctly mocks the QueryClientImpl and verifies the extension setup.

65-80: Test case for ethAccount method.

The test case correctly verifies the ethAccount method.

82-97: Test case for nibiruAccount method.

The test case correctly verifies the nibiruAccount method.

99-114: Test case for validatorAccount method.

The test case correctly verifies the validatorAccount method.

116-131: Test case for balance method.

The test case correctly verifies the balance method.

133-150: Test case for storage method.

The test case correctly verifies the storage method.

152-167: Test case for code method.

The test case correctly verifies the code method.

169-180: Test case for params method.

The test case correctly verifies the params method.

182-202: Test case for ethCall method.

The test case correctly verifies the ethCall method.

205-225: Test case for estimateGas method.

The test case correctly verifies the estimateGas method.

228-282: Test case for traceTx method.

The test case correctly verifies the traceTx method.

284-335: Test case for traceBlock method.

The test case correctly verifies the traceBlock method.

337-349: Test case for baseFee method.

The test case correctly verifies the baseFee method.

src/gql/heart-monitor/heart-monitor.test.ts (2)

208-223: Improvement: Enhanced robustness in testIbc.

The changes improve the robustness of the test by explicitly checking for null values when both ibcChannels and ibcTransfers are undefined.

290-298: Improvement: Expanded test coverage in testInflation.

The changes ensure that inflation-related data is thoroughly validated, covering additional scenarios.

src/sdk/msg/devgas.test.ts

src/sdk/msg/sudo.test.ts

src/sdk/msg/oracle.test.ts

src/gql/query/wasm.ts

src/gql/query/ibc.ts

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf2b865 and 31b305d.

Files selected for processing (2)

.github/workflows/release.yaml (1 hunks)
.github/workflows/test-ts-sdk.yaml (1 hunks)

Additional comments not posted (2)

.github/workflows/release.yaml (1)

13-14: Addition of BUF_TOKEN environment variable.

The BUF_TOKEN environment variable has been added to the release job. Ensure that this token is correctly used in the subsequent steps or actions within the workflow.

.github/workflows/test-ts-sdk.yaml (1)

15-15: Addition of BUF_TOKEN environment variable.

The BUF_TOKEN environment variable has been added to the checkout_cache_install_build_test job. Ensure that this token is correctly used in the subsequent steps or actions within the workflow.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 31b305d and dcde553.

Files selected for processing (2)

nibiru (1 hunks)
src/sdk/msg/eth.test.ts (1 hunks)

Files skipped from review due to trivial changes (1)

nibiru

Files skipped from review as they are similar to previous changes (1)

src/sdk/msg/eth.test.ts

* revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build

### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci]

* chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]>

* revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * refactor(faucet)!: set default tokens (#369) * chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> --------- Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]>

### [4.5.2](v4.5.1...v4.5.2) (2024-09-24) ### Miscellaneous Chores * develop -> main ([#370](#370)) ([ec2a25b](ec2a25b)), closes [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * **github:** Add project automation for https://tinyurl.com/25uty9w5 ([c2c27e5](c2c27e5)) [skip ci]

* chore: develop -> main (#370) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * refactor(faucet)!: set default tokens (#369) * chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> --------- Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> * chore(github): Add project automation for https://tinyurl.com/25uty9w5 * chore(release): 4.5.2 ### [4.5.2](v4.5.1...v4.5.2) (2024-09-24) ### Miscellaneous Chores * develop -> main ([#370](#370)) ([ec2a25b](ec2a25b)), closes [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * **github:** Add project automation for https://tinyurl.com/25uty9w5 ([c2c27e5](c2c27e5)) [skip ci] --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Unique Divine <[email protected]>

* chore: develop -> main (#370) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * refactor(faucet)!: set default tokens (#369) * chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> --------- Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> * chore(github): Add project automation for https://tinyurl.com/25uty9w5 * chore(release): 4.5.2 ### [4.5.2](v4.5.1...v4.5.2) (2024-09-24) ### Miscellaneous Chores * develop -> main ([#370](#370)) ([ec2a25b](ec2a25b)), closes [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * **github:** Add project automation for https://tinyurl.com/25uty9w5 ([c2c27e5](c2c27e5)) [skip ci] * feat: nibiru account parser * refactor: throw if baseaccount is undefined * test: fixing tests * chore: removing unnecessary ? * refactor: matching cosmjs implementation * chore: removing t.json * chore: pr comments --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Unique Divine <[email protected]>

…380) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * refactor(faucet)!: set default tokens (#369) * chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> * chore: main to develop (#375) * chore: develop -> main (#370) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * refactor(faucet)!: set default tokens (#369) * chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> --------- Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> * chore(github): Add project automation for https://tinyurl.com/25uty9w5 * chore(release): 4.5.2 ### [4.5.2](v4.5.1...v4.5.2) (2024-09-24) ### Miscellaneous Chores * develop -> main ([#370](#370)) ([ec2a25b](ec2a25b)), closes [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * **github:** Add project automation for https://tinyurl.com/25uty9w5 ([c2c27e5](c2c27e5)) [skip ci] --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Unique Divine <[email protected]> * feat: account parser (#374) * chore: develop -> main (#370) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * refactor(faucet)!: set default tokens (#369) * chore: develop -> main (#368) * revert: cosmos submodule only (#362) * revert: cosmos submodule only * fix: rem * fix: rem * fix: update * feat: add msg client * fix: paths * fix: try chaosnet ibc * fix: path again * fix: try hm * fix: fixes to pass * feat: eth protos (#366) * fix: eth protos * fix: client * fix: fixes * fix: try older nibiru * fix: index * fix: mainnet * fix: import * revert: build change * chore: tests (#367) * fix: all query tests * chore: final tests * fix: buf * fix: fix * fix: pull latest * fix: build * fix: build * chore(release): 4.5.1 ### [4.5.1](v4.5.0...v4.5.1) (2024-08-09) ### Miscellaneous Chores * develop -> main ([#368](#368)) ([c6d6570](c6d6570)), closes [#362](#362) [#366](#366) [#367](#367) [skip ci] * fix(faucet): remove unused tokens from default faucet request * fix: bump test --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> --------- Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> * chore(github): Add project automation for https://tinyurl.com/25uty9w5 * chore(release): 4.5.2 ### [4.5.2](v4.5.1...v4.5.2) (2024-09-24) ### Miscellaneous Chores * develop -> main ([#370](#370)) ([ec2a25b](ec2a25b)), closes [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * **github:** Add project automation for https://tinyurl.com/25uty9w5 ([c2c27e5](c2c27e5)) [skip ci] * feat: nibiru account parser * refactor: throw if baseaccount is undefined * test: fixing tests * chore: removing unnecessary ? * refactor: matching cosmjs implementation * chore: removing t.json * chore: pr comments --------- Co-authored-by: Cameron Gilbert <[email protected]> Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Unique Divine <[email protected]> * chore: remove stats and update default feature flags * feat: cosmwasmclient extension & signingcosmwasmclient implementation (#379) * feat: nibicosmwasmclient * feat: nibi signing cosm wasm client * refactor: adding nibi account parser to nibi signingcosmwasmclient * test: remove unused test file * test: take signingcosmwasmclient from coverage * chore: fix coverage --------- Co-authored-by: Kevin Yang <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Calico Nino <[email protected]> Co-authored-by: Unique Divine <[email protected]>

## [5.0.0](v4.5.2...v5.0.0) (2024-10-18) ### ⚠ BREAKING CHANGES * **faucet:** set default tokens (#369) ### Features * account parser ([#374](#374)) ([d7e324d](d7e324d)), closes [#370](#370) [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * add msg client ([32374dd](32374dd)) * cosmwasmclient extension & signingcosmwasmclient implementation ([#379](#379)) ([b89a700](b89a700)) * eth protos ([#366](#366)) ([9d496c7](9d496c7)), closes [#367](#367) ### Bug Fixes * build ([b9b3d74](b9b3d74)) * build ([79fcd49](79fcd49)) * fixes to pass ([0c3f86a](0c3f86a)) * path again ([e5f1ff3](e5f1ff3)) * paths ([c762665](c762665)) * pull latest ([35eb2d8](35eb2d8)) * try chaosnet ibc ([d66c15c](d66c15c)) * try hm ([954f259](954f259)) ### Reverts * cosmos submodule only ([#362](#362)) ([1d09461](1d09461)) ### Code Refactors * **faucet:** set default tokens ([#369](#369)) ([859882a](859882a)), closes [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) ### Miscellaneous Chores * develop -> main ([5518ddd](5518ddd)) * develop -> main (remove stats + update default feature flags) ([#380](#380)) ([087d569](087d569)), closes [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * main to develop ([#375](#375)) ([49b0766](49b0766)), closes [#370](#370) [#362](#362) [#366](#366) [#367](#367) [#369](#369) [#368](#368) [#362](#362) [#366](#366) [#367](#367) [#362](#362) [#366](#366) [#367](#367) * remove stats and update default feature flags ([56bef2a](56bef2a)) * trigger release ([d89c408](d89c408)) [skip ci]

nibibot · 2024-10-18T14:00:10Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cgilbe27 added 2 commits July 29, 2024 09:26

fix: eth protos

dd041d7

fix: client

a1ab286

cgilbe27 self-assigned this Jul 29, 2024

cgilbe27 requested a review from CalicoNino July 29, 2024 13:33

cgilbe27 added 5 commits July 29, 2024 09:55

fix: fixes

7a8b404

fix: try older nibiru

6363ef5

fix: index

3025c56

fix: mainnet

11472b9

fix: import

8af6d3a

cgilbe27 marked this pull request as ready for review July 29, 2024 14:20

revert: build change

b40ff85

cgilbe27 enabled auto-merge (squash) July 29, 2024 14:24

cgilbe27 changed the title ~~fix: eth protos~~ feat: eth protos Jul 29, 2024

coderabbitai bot reviewed Jul 29, 2024

View reviewed changes

src/sdk/msg/eth.ts Show resolved Hide resolved

src/sdk/msg/inflation.ts Show resolved Hide resolved

src/sdk/query/tokenfactory.ts Outdated Show resolved Hide resolved

cgilbe27 marked this pull request as draft July 30, 2024 15:00

auto-merge was automatically disabled July 30, 2024 15:00
Pull request was converted to draft

cgilbe27 added 3 commits August 1, 2024 07:23

chore: tests (#367)

efc0023

fix: all query tests

6af3955

chore: final tests

cf2b865

cgilbe27 marked this pull request as ready for review August 2, 2024 17:06

coderabbitai bot reviewed Aug 2, 2024

View reviewed changes

fix: buf

31b305d

coderabbitai bot reviewed Aug 2, 2024

View reviewed changes

fix: fix

dcde553

coderabbitai bot reviewed Aug 2, 2024

View reviewed changes

cgilbe27 enabled auto-merge (squash) August 3, 2024 03:00

CalicoNino approved these changes Aug 6, 2024

View reviewed changes

cgilbe27 merged commit 9d496c7 into develop Aug 6, 2024
5 checks passed

cgilbe27 deleted the feat/eth-proto branch August 6, 2024 14:35

CalicoNino mentioned this pull request Oct 18, 2024

chore: main to develop #381

Closed

nibibot added the released label Oct 18, 2024

This was referenced Oct 18, 2024

feat: add msg client #364

Merged

refactor: latest gql schema update to account for removal of spot & perp from feature flags #385

Merged

coderabbitai bot mentioned this pull request Nov 20, 2024

refactor: adding eth & tokenfactory types #389

Merged

coderabbitai bot mentioned this pull request Dec 2, 2024

chore: bump nibiru submodule and unhide protojs and gql so we can tra… #393

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: eth protos #366

feat: eth protos #366

cgilbe27 commented Jul 29, 2024 •

edited

Loading

coderabbitai bot commented Jul 29, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jul 29, 2024 •

edited

Loading

coderabbitai bot left a comment

cgilbe27 commented Jul 30, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

nibibot commented Oct 18, 2024

feat: eth protos #366

feat: eth protos #366

Conversation

cgilbe27 commented Jul 29, 2024 • edited Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 29, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jul 29, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

cgilbe27 commented Jul 30, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

nibibot commented Oct 18, 2024

cgilbe27 commented Jul 29, 2024 •

edited

Loading

coderabbitai bot commented Jul 29, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 29, 2024 •

edited

Loading