Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrading cosmjs #352

Merged
merged 2 commits into from
May 13, 2024
Merged

chore: upgrading cosmjs #352

merged 2 commits into from
May 13, 2024

Conversation

CalicoNino
Copy link
Contributor

@CalicoNino CalicoNino commented May 13, 2024

Summary by CodeRabbit

  • Chores
    • Updated dependencies to improve performance and compatibility with newer protocols.

@CalicoNino CalicoNino requested a review from cgilbe27 May 13, 2024 10:55
@CalicoNino CalicoNino self-assigned this May 13, 2024
Copy link
Contributor

coderabbitai bot commented May 13, 2024

Walkthrough

The recent update involves a version bump for four key dependencies in the package.json file and a type conversion in event.test.ts for gas-related values. These changes aim to enhance functionality and compatibility within the project, ensuring smoother operation and potentially improved performance.

Changes

File Change Summary
package.json Updated versions of @cosmjs/cosmwasm-stargate, @cosmjs/proto-signing, @cosmjs/stargate, @cosmjs/tendermint-rpc from 0.31.0 to 0.32.3.
src/sdk/tx/event.test.ts Converted gasUsed and gasWanted values to BigInt type by using BigInt(0) instead of 0.

🐇🎉
In the garden of code, under the moon so bright,
Four little packages grew overnight.
From .31 to .32.3, they sprang,
Now my project can dance and sing!
Hip-hop hurray for the updates we adore,
May our code run smoothly, forevermore!
🌟🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c7b1150 and 67f9d2e.
Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/*.lock
Files selected for processing (1)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • package.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 67f9d2e and b7fbec3.
Files selected for processing (1)
  • src/sdk/tx/event.test.ts (1 hunks)
Additional comments not posted (1)
src/sdk/tx/event.test.ts (1)

36-37: Conversion of gasUsed and gasWanted to BigInt is appropriate for handling larger values.

This change ensures that the system can handle larger gas values without integer overflow, which is crucial for maintaining the robustness and accuracy of gas calculations in blockchain transactions.

Copy link

Lines Statements Branches Functions
Coverage: 88%
90.29% (1014/1123) 72.2% (304/421) 76.48% (244/319)

@CalicoNino CalicoNino merged commit 32739a7 into develop May 13, 2024
3 checks passed
@CalicoNino CalicoNino deleted the chore/upgrade-cosmjs branch May 13, 2024 15:56
CalicoNino added a commit that referenced this pull request May 13, 2024
* chore: upgrading cosmjs

* fix: bigint error type
nibibot pushed a commit that referenced this pull request May 13, 2024
### [4.3.1](v4.3.0...v4.3.1) (2024-05-13)

### Miscellaneous Chores

* upgrading cosmjs ([#352](#352)) ([#353](#353)) ([2f119c5](2f119c5))

 [skip ci]
nibibot pushed a commit that referenced this pull request May 16, 2024
### [4.3.2](v4.3.1...v4.3.2) (2024-05-16)

### Miscellaneous Chores

* upgrading cosmjs ([#352](#352)) ([32739a7](32739a7))

 [skip ci]
@nibibot
Copy link

nibibot commented May 16, 2024

🎉 This PR is included in version 4.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants