ci: bump to golang v1.21 #1698
ci: bump to golang v1.21 #1698
Conversation
WalkthroughThe changes across various files indicate a systematic update of the Go language version from 1.19 to 1.21 in the project's GitHub Actions workflows, Dockerfiles, and build scripts. This update likely aims to leverage improvements and new features in the latest Go release, ensuring the project's build and test environments are current. Changes
TipsChat with CodeRabbit Bot (
|
Run markdown linter on changelog.md
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- go.mod
- go.sum
Files selected for processing (10)
- .github/workflows/golangci-lint.yml (1 hunks)
- .github/workflows/integration-tests.yml (1 hunks)
- .github/workflows/sims.yml (2 hunks)
- .github/workflows/unit-tests.yml (2 hunks)
- CHANGELOG.md (10 hunks)
- Dockerfile (1 hunks)
- contrib/docker/chaosnet.Dockerfile (1 hunks)
- contrib/docker/goreleaser.Dockerfile (1 hunks)
- contrib/make/release.mk (2 hunks)
- contrib/scripts/release_pre_darwin.sh (1 hunks)
Files skipped from review due to trivial changes (5)
- .github/workflows/unit-tests.yml
- Dockerfile
- contrib/docker/chaosnet.Dockerfile
- contrib/make/release.mk
- contrib/scripts/release_pre_darwin.sh
Additional comments: 10
.github/workflows/golangci-lint.yml (1)
- 26-29: The update of the
go-versionto1.21in the GitHub Actions workflow is consistent with the PR objective to update the Go version used in the codebase. This change will ensure that the linter runs with the updated Go version..github/workflows/integration-tests.yml (1)
- 24-29: The update of the
go-versionto 1.21 in the GitHub Actions workflow is consistent with the PR objective and the summary provided. This change will ensure that the integration tests are run using the updated Go version..github/workflows/sims.yml (2)
11-17: The update of the
go-versionto1.21in theactions/setup-gostep is consistent with the PR objective to upgrade the Go version used in the codebase. This change will ensure that the GitHub Actions workflow uses the correct version of Go for theinstall-runsimjob.33-39: Similarly, the
go-versionis updated to1.21in theactions/setup-gostep for thetest-sim-nondeterminismjob, aligning with the PR objective. This ensures that the testing environment is consistent with the new Go version.CHANGELOG.md (5)
43-49: The hunk correctly reflects the state machine breaking changes for the next mainnet version as mentioned in the summary.
73-77: The hunk correctly reflects the dependency updates, including the bump of
golangfrom 1.19 to 1.21, which aligns with the PR objective and the summary provided.93-106: The hunk shows state machine breaking changes for the v1.0.0 release, which is consistent with the summary provided.
139-150: The hunk correctly reflects the dependency updates for the v1.0.0 release, which is consistent with the summary provided.
440-447: The hunk correctly reflects the dependency updates for the v0.19.4 release, which is consistent with the summary provided.
contrib/docker/goreleaser.Dockerfile (1)
- 1-4: The update to the base image from
golang:1.19togolang:1.21is consistent with the PR objective to use Go version 1.21.
| * [#1322](https://gitub.com/NibiruChain/nibiru/pull/1322) - build(deps): Bumps github.com/armon/go-metrics from 0.4.0 to 0.4.1. | ||
| * [#1319](https://github.com/NibiruChain/nibiru/pull/1319) - test: add integration test actions | ||
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(testutil): Use secp256k1 algo for private key generation in common/testutil. | ||
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | ||
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | ||
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | ||
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | ||
| * [#1315](https://github.com/NibiruChain/nibiru/pull/1315) - feat: oracle rewards distribution every week | ||
| * [#1315](https://github.com/NibiruChain/nibiru/pull/1315) - feat: oracle rewards distribution every week | ||
| * [#1312](https://github.com/NibiruChain/nibiru/pull/1312) - feat(wasm): wire depth shift handler to the wasm router |
There was a problem hiding this comment.
There is a typo in the URL for the pull request #1322, which should be corrected to maintain the integrity of the changelog.
- * [#1322](https://gitub.com/NibiruChain/nibiru/pull/1322) - build(deps): Bumps github.com/armon/go-metrics from 0.4.0 to 0.4.1.
+ * [#1322](https://github.com/NibiruChain/nibiru/pull/1322) - build(deps): Bumps github.com/armon/go-metrics from 0.4.0 to 0.4.1.Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * [#1322](https://gitub.com/NibiruChain/nibiru/pull/1322) - build(deps): Bumps github.com/armon/go-metrics from 0.4.0 to 0.4.1. | |
| * [#1319](https://github.com/NibiruChain/nibiru/pull/1319) - test: add integration test actions | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(testutil): Use secp256k1 algo for private key generation in common/testutil. | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | |
| * [#1315](https://github.com/NibiruChain/nibiru/pull/1315) - feat: oracle rewards distribution every week | |
| * [#1315](https://github.com/NibiruChain/nibiru/pull/1315) - feat: oracle rewards distribution every week | |
| * [#1312](https://github.com/NibiruChain/nibiru/pull/1312) - feat(wasm): wire depth shift handler to the wasm router | |
| * [#1322](https://github.com/NibiruChain/nibiru/pull/1322) - build(deps): Bumps github.com/armon/go-metrics from 0.4.0 to 0.4.1. | |
| * [#1319](https://github.com/NibiruChain/nibiru/pull/1319) - test: add integration test actions | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(testutil): Use secp256k1 algo for private key generation in common/testutil. | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | |
| * [#1317](https://github.com/NibiruChain/nibiru/pull/1317) - feat(sudo): Implement and test CLI commands for tx and queries. | |
| * [#1315](https://github.com/NibiruChain/nibiru/pull/1315) - feat: oracle rewards distribution every week | |
| * [#1315](https://github.com/NibiruChain/nibiru/pull/1315) - feat: oracle rewards distribution every week | |
| * [#1312](https://github.com/NibiruChain/nibiru/pull/1312) - feat(wasm): wire depth shift handler to the wasm router |
* feat: bump to golang v1.21 * ci: bump golang cross version to 1.21.5 * fix: osxcross directory changed * Update CHANGELOG.md Run markdown linter on changelog.md
Description
Bumps the codebase to use Golang v1.21
Purpose
Potential language improvements, and the new version of rocksdb requires it.
Summary by CodeRabbit
Chores
golang:1.19togolang:1.21to incorporate the latest features and optimizations available in the Go language.goreleaserflags for more efficient release processes.Documentation
Refactor