Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app)!: enforce min commission by changing default and genesis validation #1613

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

Unique-Divine
Copy link
Member

Description

  1. Changes the default value for staking.params.min_commission in the genesis.
  2. Wraps the current genesis validation handler for x/staking to error if the minimum commission is nonpositive.

Purpose

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1613 (9e5b35a) into master (0c31eaf) will increase coverage by 0.51%.
Report is 3 commits behind head on master.
The diff coverage is 89.39%.

❗ Current head 9e5b35a differs from pull request most recent head 492ea94. Consider uploading reports for the commit 492ea94 to get more accurate results

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   71.21%   71.72%   +0.51%     
==========================================
  Files         186      185       -1     
  Lines       14493    14562      +69     
==========================================
+ Hits        10321    10445     +124     
+ Misses       3520     3468      -52     
+ Partials      652      649       -3     
Files Coverage Δ
x/perp/v2/keeper/keeper.go 92.42% <100.00%> (+1.35%) ⬆️
x/perp/v2/module/genesis.go 98.03% <100.00%> (+23.41%) ⬆️
app/modules.go 94.64% <76.92%> (-5.36%) ⬇️
x/perp/v2/keeper/clearing_house.go 77.41% <25.00%> (-0.08%) ⬇️
x/perp/v2/keeper/dnr.go 89.47% <88.57%> (+22.03%) ⬆️

... and 1 file with indirect coverage changes

@Unique-Divine Unique-Divine enabled auto-merge (squash) September 29, 2023 13:30
@Unique-Divine Unique-Divine merged commit 930a890 into master Sep 29, 2023
@Unique-Divine Unique-Divine deleted the realu/min-commission branch September 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ante): set minimum commission percentage for validating
2 participants