Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): remove dead code in app setup #1560

Merged
merged 2 commits into from
Aug 31, 2023
Merged

refactor(app): remove dead code in app setup #1560

merged 2 commits into from
Aug 31, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Aug 31, 2023

Description

  • Removes unused code in app setup
  • Clean up import list
  • General style fixes

Purpose

Makes app setup easier to read

@k-yang k-yang requested a review from a team as a code owner August 31, 2023 08:59
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Unique-Divine Unique-Divine merged commit d0bc884 into master Aug 31, 2023
14 of 15 checks passed
@Unique-Divine Unique-Divine deleted the refactor/app/module-setup branch August 31, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgimeno jgimeno jgimeno approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-yang @jgimeno @Unique-Divine