MCS - 1926 - Delete temporary files when browser session is ended #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDCACI
requested review from
rartiss55,
ThomasSchellenbergNextCentury and
phile-caci
NDCACI
changed the title
| app.logger.info(f'{"Deleting static/mcsinterface/ folders"}') | ||
| os.system("find ./static/mcsinterface -name 'cmd_*' | xargs rm -r") | ||
| os.system("find ./static/mcsinterface -name 'output_*' | xargs rm -r") | ||
| os.system("find ./static/mcsinterface -name 'img_*' | xargs rm -r") |
There was a problem hiding this comment.
For me, I don't see any img_* files in my static/mcsinterface/ folder (is it an OS-specific thing?), but having it here doesn't hurt.
There was a problem hiding this comment.
The img_* are folders that the rbg_* files that Rachel mentioned. Thats what they are for me.
| 'ffmpeg', '-y', '-r', '20', '-i', | ||
| 'ffmpeg', '-y', '-r', '20', '-i', '-q:v', '1', |
There was a problem hiding this comment.
Out of curiosity, what is this change for?
There was a problem hiding this comment.
Its something Phi changed while helping me with my import issue.
There was a problem hiding this comment.
Yikes... can you revert that, it was something I was testing.
rartiss55
approved these changes
Dec 12, 2023
ThomasSchellenbergNextCentury
merged commit 66bd017
into
new-webenabled
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.