add GGUF model router support across all model types & refactor the code #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltimodal, and Audio) in Streamlit & refactor the code
zhiyuan8
requested changes
Nov 8, 2024
| # get model specific defaults: | ||
| default_params = get_default_params(model_to_check) | ||
|
|
||
| # adjust step range based on model type: |
There was a problem hiding this comment.
You should read in those parameters from
https://github.com/NexaAI/nexa-sdk/blob/main/nexa/constants.py#L311-L353
use
DEFAULT_IMG_GEN_PARAMS_LCM.num_inference_steps
There was a problem hiding this comment.
@zhiyuan8 Let me clarify the get_default_params() approach:
Different computer vision models require their own default parameters. More specifically,
- LCM models → DEFAULT_IMG_GEN_PARAMS_LCM (4 steps, 1.0 guidance)
- SDXL-turbo → DEFAULT_IMG_GEN_PARAMS_TURBO (5 steps, 5.0 guidance)
- Standard SD models → DEFAULT_IMG_GEN_PARAMS (20 steps, 7.5 guidance)
The get_default_params function at https://github.com/NexaAI/nexa-sdk/blob/qingying-model-router-streamlit/nexa/gguf/streamlit/streamlit_image_chat.py#L23-L30 picks the right parameter set based on model name(type). Happy to add clearer documentation, or let me know if I didn't get your point.
zhiyuan8
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.