Feature Implementation for issue #136 : supports vlm requests for /chat/completions api #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhycheng614
commented
Oct 8, 2024
•
zhycheng614
commented
- updates on the existing api: /chat/completions api to be compatible with OpenAI api
- supports streaming
- running model from local path supported, with --local_path and --model_type flags provided
…ovided but vlm message input
zhiyuan8
approved these changes
Oct 9, 2024
|
|
||
| ```json | ||
| { | ||
| "model": "anything", |
There was a problem hiding this comment.
Please use an actual model name, developers may just want to copy it and it should work
| @@ -15,13 +15,41 @@ def run_ggml_inference(args): | |||
| if model_type: | |||
| run_type = ModelType[model_type].value | |||
|
|
|||
| def choose_file(local_path, file_type): | |||
| """ Helper function for Multimodal inference only: select the model and projector ggufs from the local_path. """ | |||
There was a problem hiding this comment.
why don't we split proj and model file into two arguments? We might want to add a flag "--proj" or "-p" for projector. What if I mistakenly write proj at 1st position?
There was a problem hiding this comment.
please confirm this UX with product @alanzhuly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.