Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update extracellular electrophysiology tutorial #2012

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Dec 18, 2024

Motivation

Update some of the recently added examples in the extracellular ephys tutorial and address nwbinspector warnings.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (2c2bc85) to head (70780fa).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2012   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          27       27           
  Lines        2708     2708           
  Branches      707      707           
=======================================
  Hits         2483     2483           
  Misses        149      149           
  Partials       76       76           
Flag Coverage Δ
integration 72.82% <ø> (ø)
unit 82.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince requested a review from oruebel December 18, 2024 18:58
@stephprince stephprince marked this pull request as ready for review December 18, 2024 18:58
@stephprince
Copy link
Contributor Author

@ehennestad I updated the text based on your suggestions and referencing the latest matnwb tutorials - let me know if you had any other suggestions!

@stephprince stephprince merged commit 80fc386 into dev Dec 19, 2024
26 checks passed
@stephprince stephprince deleted the update-ecephys-tutorial branch December 19, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants