-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model_number
, model_name
, and serial_number
to Device
#1997
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nwb_schema_2.8.0 #1997 +/- ##
===================================================
Coverage ? 91.93%
===================================================
Files ? 27
Lines ? 2715
Branches ? 708
===================================================
Hits ? 2496
Misses ? 145
Partials ? 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for updating the tutorial examples as well.
If we wanted to be consistent throughout, we could also update the ogen and icephys docs:
pynwb/docs/gallery/domain/ogen.py
Lines 43 to 47 in 084aa55
device = nwbfile.create_device( | |
name="device", | |
description="description of device", | |
manufacturer="optional but recommended", | |
) |
pynwb/docs/gallery/domain/icephys.py
Line 55 in 084aa55
device = nwbfile.create_device(name="Heka ITC-1600") |
but I don't know if that's really necessary.
I thought that too but I was not sure what the best example values for those are... do you have any suggestions? We could also punt this to an issue for a later fix. |
I'm also not sure what the best examples would be... I'm good punting to a separate issue and getting feedback from someone who currently uses those techniques. |
Motivation
See NeurodataWithoutBorders/nwb-schema#594
Checklist
ruff check . && codespell
from the source directory.