Add default name="units"
to Units
object in the mock_Units
testing function
#1883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this discussion here:
#1882
This is a quality of life small change that would allow two things to work:
https://github.com/h-mayorquin/pynwb/blob/ad6b0283c49ce8c391fd1b0e6ced3d0f6907c17d/src/pynwb/testing/mock/ecephys.py#L148-L150
The only downside is that for
Units
object that are destined for some other places of the nwbfile (.e.g processing) this will not follow the best practices. As these are functions that are mainly used for testing I think that this is not a big deal.