-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: Only embed specs/namespaces for types that are included in NWB file on export #615
Open
ehennestad
wants to merge
44
commits into
master
Choose a base branch
from
607-fix-namespace-embedding-in-file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 95.24% 95.19% -0.05%
==========================================
Files 117 137 +20
Lines 4902 5165 +263
==========================================
+ Hits 4669 4917 +248
- Misses 233 248 +15 ☔ View full report in Codecov by Sentry. |
ehennestad
changed the title
Change: Only include namespaces for types that are included in NWB file on export
Change: Only embed specs/namespaces for types that are included in NWB file on export
Nov 6, 2024
Update docstring
Add utility function for listing the type hierarchy of an nwb type
…ataWithoutBorders/matnwb into add-nwb-install-extension
Add schedule event for workflow to update nwbInstallExtension
Remove local function
Co-authored-by: Ben Dichter <[email protected]>
…extension_api.rst Co-authored-by: Ben Dichter <[email protected]>
Add example to docstring
Introduce some functions that will be useful later
Add arguments block, fix function name
Redefine listNwbTypes method, add validation of embedded namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #607
Motivation
Ensure that only relevant namespaces/specifications are embedded in an NWB file. This issue suggests that such extra namespaces can cause errors when validating with NWBInspector.
How to test the behavior?
Questions / todo
kebab-case
? - Appears sosnake_case
? - Appears soShould thespecification
group be completely cleared before rewriting it if exporting to an existing file?Checklist
fix #XX
whereXX
is the issue number?