Refactor Connection Sparsity #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connection sparsity can be calculated directly looking at the name of the parameters in the state dict
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #240 +/- ##
==========================================
+ Coverage 64.69% 65.36% +0.67%
==========================================
Files 16 16
Lines 796 745 -51
Branches 161 147 -14
==========================================
- Hits 515 487 -28
+ Misses 239 221 -18
+ Partials 42 37 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Also consider the biases, like in RNN. And should track parameters named with 'bias' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an extension to calculate the connection sparsity of the model.
From now on, it is possible to calculate the connection sparsity even though the model doesn't have layers supported by the documentation list.