Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rnncell synops calculation #227

Merged
merged 5 commits into from
Jul 24, 2024
Merged

update rnncell synops calculation #227

merged 5 commits into from
Jul 24, 2024

Conversation

jasonlyik
Copy link
Contributor

Updating LSTMCell and GRUCell synops calculation,

Previously the reshape of ifgo/rzn for the LSTM/GRU blocks assumed batch=1 and flattened the hidden features.

Changed to arbitrary batch size.

No difference in output for the unittests or LSTM example for mackey_glass.

@jasonlyik
Copy link
Contributor Author

@korneelf1 Can you check over these changes to see if they look correct?

@korneelf1 korneelf1 merged commit dd998f0 into dev Jul 24, 2024
2 checks passed
@korneelf1 korneelf1 deleted the fix/lstm_syn_ops branch July 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants