-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up pre-commit hooks to enhance code formatting and linting #196
Conversation
@ben9809 Looks pretty good.
These are both expected behavior, right? I think we can add a bit more detail to the contributing text if so. |
Yes, the behavior you're observing is expected when working with pre-commit hooks in git. |
I'd like to propose the following enhancement for our code quality process: we could enforce our code quality standards server-side, by integrating pre-commit checks into our GitHub Actions workflow, such that if a developer forgets to run pre-commit locally, our codebase's integrity is safeguarded, as the checks will automatically run on the server when a pull request is opened on the dev branch. (This is still not integrated into this pull request) Let me know your thoughts @jasonlyik! |
Sounds great, I think doing the server-side checks and making the format changes at PR time sounds pretty good, so that it's easier to develop locally. |
…er to format documentation, update gitignore
…er to format documentation, update gitignore
@jasonlyik Before we merge this pull request, I'd like to discuss some issues with certain files during our next development meeting. This way, we can decide together how to manage them! |
Sounds good, let's take a look next meeting |
This pull request introduces pre-commit hooks to our project to automate and enhance code quality. Integrating these hooks will ensure that every commit complies with our coding standards.
Changes include:
.pre-commit-config.yaml
file configuring Black and Flake8.Developers must set up pre-commit on their local environments to benefit from these hooks.