OpenEphysBinary: Skip streams if folder doesn't exist #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
Nov 4, 2024
| @@ -1,4 +1,5 @@ | |||
| import unittest | |||
| import pytest | |||
alejoe91
commented
Nov 4, 2024
| @@ -1,4 +1,5 @@ | |||
| import unittest | |||
| import pytest | |||
There was a problem hiding this comment.
I found a built in unit test function instead..removing!
alejoe91
commented
Nov 4, 2024
zm711
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Sorry one last question:
Are events and continuous completely separate? Or are they paired in some way? Or can I record just event or just continuous for different experiments? I just want to make sure the skipping stream strategy is best or are there cases where we should raise a hard error. For example what if someone deletes everything will this fail and say empty or would this pass with a bunch of warnings that could be shut off?
|
they could be separate, but some have both. On the NEO side of things, they are separate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has come up several times in the past. If a user deletes a stream subfolder (even if irrelevane, e.g., MessageCenter) the RawIO fails to read the folder.
This PR simply skips missing folders.
@zm711 I'll add a test file to GIN