Gain calculation for Neuropixel 2.0 might be wrong #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the gain changed from 80 to 100 in the commercial probes, as confirmed here. It's better to read this from the metafile as well, field |
|
@alejoe91 Please have a look, thanks! :) |
alejoe91
reviewed
Jan 26, 2024
alejoe91
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For commercial 2.0 probes, the manual says the ADC is 12 bits, which would make the highest positive value to be 2048, not 8192, as is hardcoded in the code. In the metadata of my recordings,
imMaxInt=2048.Jennifer Colonnel's code here uses the imMaxInt to calculate the gain factor.