add colorized output and symbols in terminal #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moejoe90
requested changes
Jan 10, 2018
src/command.js
Outdated
| @@ -17,6 +17,7 @@ const defaultQuickMode = false; | |||
| const defaultSaveState = null; | |||
| const defaultOutputType = 'terminal'; | |||
| const defaultAccessToken = ''; | |||
| const defaultColors = '1'; // No color 1 Ansi, 2 Chalk | |||
src/command.js
Outdated
| @@ -109,6 +110,7 @@ export default (watchPath) => { | |||
| .option('-l, --log-level [n]', 'Log level', handelInputValues('LOG_LEVEL', watchConfig.logLevel, defaultLogLevel)) | |||
| .option('-o,--output-type [n]', 'Output type', handelInputValues('OUTPUT_TYPE', watchConfig.outputType, defaultOutputType)) | |||
| .option('-e,--access-token [n]', 'etherscan access token', handelInputValues('ACCESS_TOKEN', watchConfig.accessToken, defaultAccessToken)) | |||
| .option('-c,--colors [n]', 'use color 1 for ansi, 2 for chalk, any other for none', handelInputValues('COLORS', watchConfig.colors, defaultColors)) | |||
There was a problem hiding this comment.
let's make it three values 1,2,empty any other value should raise an exception
| @@ -12,6 +12,6 @@ export default (data, type = 'terminal') => { | |||
| data.decodedInputDataResult, data.decodedLogs))); | |||
| break; | |||
| default: | |||
| throw new Error(`${type} output module is undefind`); | |||
| throw new Error(`${type} output module is undefined`); | |||
src/output/terminalFormat.js
Outdated
| green: styleFactory('green'), | ||
| red: styleFactory('red'), | ||
| yellow: styleFactory('yellow'), | ||
| // blue: styleFactory('blue'), |
src/output/terminalFormat.js
Outdated
| @@ -1,22 +1,87 @@ | |||
| import { getCommandVars } from '../command.js'; | |||
|
|
|||
| // Dep modules | |||
src/output/terminalFormat.js
Outdated
| export default (data) => { | ||
| const txHash = data.transaction.hash; | ||
| function styleFactory(color) { |
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 74.24% 74.31% +0.07%
==========================================
Files 11 11
Lines 365 366 +1
==========================================
+ Hits 271 272 +1
Misses 94 94
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 74.93% 74.31% -0.62%
==========================================
Files 11 11
Lines 395 366 -29
==========================================
- Hits 296 272 -24
+ Misses 99 94 -5
Continue to review full report at Codecov.
|
# Conflicts: # README.md # src/command.js # src/output/terminalFormat.js
|
feedback implemented and PR up to date with master |
Moejoe90
requested changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add colored terminal and symbols :)