Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solmate Utils Bytes32AddressLib.sol transpiles after type changes #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarcusWentz
Copy link

No description provided.

@MarcusWentz MarcusWentz changed the title Test with README info Solmate Utils Bytes32AddressLib.sol transpiles after type changes Feb 26, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both functions in this contract are internal, so they are not reachable from an external or public function, that's why you can't see them in the output. The transpiler contains a pass that removes unreachable functions from the code, mainly, because during the transpilation extra functions are added. If you would like to transpile these functions as well, a small patch you could use is to change their visibility.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to add this information inside the folder where the contract is (maybe create another readme file for that), instead of changing the readme of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants