Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWTsecret to relative path #484

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

stdevMac
Copy link
Member

Changes:

  • When not provided, the jwt secret is set as a relative path. This allows users to share their setup more easily.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.76%. Comparing base (6e485d7) to head (5b2a894).

Files with missing lines Patch % Lines
cli/actions/jwt_secrets.go 72.72% 2 Missing and 1 partial ⚠️
cli/generate.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #484   +/-   ##
========================================
  Coverage    24.75%   24.76%           
========================================
  Files          120      120           
  Lines        22299    22317   +18     
========================================
+ Hits          5521     5527    +6     
- Misses       16235    16243    +8     
- Partials       543      547    +4     
Flag Coverage Δ
unittests 24.76% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing something. I don't see any regression tests that check what happens when the user uses a relative path, or an absolute path. These should be E2E tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants