refactor(sync): Move ProgressTracker initialization to dedicated method #8074
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move initialization logic from the constructor to a dedicated Initialize method in ProgressTracker. This improves code organization by separating concerns and makes the initialization process more maintainable. - Create new Initialize method to encapsulate initialization logic - Move SetupAccountRangePartition and GetSyncProgress calls to Initialize - Keep constructor focused on parameter validation and field initialization - Remove TODO comment as the suggested improvement has been implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # N/A
Changes
Initialize()method inProgressTrackerTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
This refactoring improves code maintainability by following the Single Responsibility Principle. The initialization logic is now encapsulated in a dedicated method, making the code more modular and easier to understand. This change is purely internal and doesn't affect the public API or behavior of the
ProgressTrackerclass.