Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/range receipt migration #8047

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature/range receipt migration #8047

wants to merge 6 commits into from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jan 14, 2025

  • Allow debug_migrateReceipts to specify from and to.
  • Account for strange off by one migration. The from and to is not inclusive.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Called manually.

@asdacap asdacap requested a review from kamilchodola January 14, 2025 07:33
@kamilchodola
Copy link
Contributor

@asdacap As we still did not deprecated CLI this method needs to be adjusted for CLI as well

@asdacap
Copy link
Contributor Author

asdacap commented Jan 14, 2025

I think its fine. CLI should not really need anything complicated as this is not normally done.

@LukaszRozmej LukaszRozmej mentioned this pull request Jan 15, 2025
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asdacap @kamilchodola @benaadams