-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EvmStack native endian #8037
Draft
Scooletz
wants to merge
20
commits into
master
Choose a base branch
from
evm-stack-native-endian
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
EvmStack native endian #8037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scooletz
force-pushed
the
evm-stack-native-endian
branch
2 times, most recently
from
January 16, 2025 12:16
4e48a4c
to
4b804ef
Compare
Scooletz
force-pushed
the
evm-stack-native-endian
branch
from
January 16, 2025 13:49
4b804ef
to
8f8c479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the endianness of the
EvmStack
to be aligned with the platform it runs on. It means that no endianness conversions should be done when retrieving storingUInt256
. The penalty though is related to pushing/poping bytes that now require reversing. According to the profiling this should happen much less frequent than regular operations.Beside the endiannes, this PR add one method that allows to peek a
ref UInt256
to the top of the stack. This allows for anyInstruction
that has push/pop behavior to get a ref to the last parameter and directly set the value on the stack, without performing calculations for pop and push. Instead it will calculated the offset once for getting theref
and use it for pop.Changes
EvmStack
uses now native platform endianessEvmStack
allows peeking a ref to the topTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.