Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change/use persisted pointer for fast header #7855

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 3, 2024

  • Currently unlike oldbodies, orldreceipt or beacon header, the pointer for fast header is initialized via binary search from genesis to sync pivot.
  • This cause a problem with era/portal which may insert header in between arbitrarily.
  • This change the pointer to be persisted like beacon header and the pointer is changed manually in fast header instead of on every block/header insert.
  • Also don't download already persisted header. This only 2x faster than downloading though.

Types of changes

What types of changes does your code introduce?

  • Optimization
  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Mainnet sync work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant