Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmark runner .NET version #7850

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

Marchhill
Copy link
Contributor

Changes

  • Update Core runtime library for BenchmarkDotNet benchmarks

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@LukaszRozmej
Copy link
Member

Do we need to update benchmark .net to the newest version in order to have best compatibility? Or is it already updated?

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixed the issue with Benchmarks, LGTM!

@Marchhill Marchhill merged commit 9ff58a0 into master Dec 3, 2024
79 checks passed
@Marchhill Marchhill deleted the fix/benchmark-runner-version branch December 3, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants