TrieStore to Channels #7845
Draft
TrieStore to Channels #7845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
LukaszRozmej
reviewed
Dec 1, 2024
| } | ||
| }); | ||
| } | ||
| await foreach (var disposable in disposeQueue.Reader.ReadAllAsync()) |
There was a problem hiding this comment.
will it correctly partition items from channel between 4 tasks/threads here?
| writeBatch = _nodeStorage.StartWriteBatch(); | ||
| } | ||
| } | ||
|
|
||
| tn.CallRecursively(DoPersist, address2, ref path, GetTrieStore(address2), true, _logger); | ||
| disposeQueue.Add(writeBatch); | ||
| await tn.CallRecursivelyAsync(DoPersist, address2, path, GetTrieStore(address2), true, _logger); |
There was a problem hiding this comment.
Not sure if this can break anything... probably not
Comment on lines
+1012
to
+1014
| int previousLength = AppendChildPath(ref currentPath, i); | ||
| await child.CallRecursivelyAsync(action, storageAddress, currentPath, resolver, skipPersisted, logger, maxPathLength, resolveStorageRoot); | ||
| currentPath.TruncateMut(previousLength); |
There was a problem hiding this comment.
No point to mutate the path as we have to do the copy anyways?
asdacap
approved these changes
Dec 2, 2024
|
Will wait on this as might be better way to do it with #7787 without introducing a second code path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ConcurrentQueuein aBlockingCollectionburns a ton of CPU spinning; whereas its a pattern ideally suited toChannels; and using trueasyncTypes of changes
What types of changes does your code introduce?
Testing
Requires testing