7702 changes for devnet 5 #7781
Conversation
| @@ -793,6 +779,53 @@ public void Execute_SetNormalDelegationAndThenSetDelegationWithZeroAddress_Accou | |||
| Assert.That(_stateProvider.HasCode(authority.Address), Is.False); | |||
| } | |||
|
|
|||
| [TestCase(true)] | |||
| [TestCase(false)] | |||
| public void Execute_EXTCODESIZEOnDelegatedThatTriggersOptimization_ReturnsZeroIfDelegated(bool isDelegated) | |||
There was a problem hiding this comment.
should test name be ReturnsTwoIfDelegated?
There was a problem hiding this comment.
This test is about testing a specific optimization path in EXTCODESIZE, which will return a one or zero. Its used for contracts to determine if an address is an EOA or not.
There was a problem hiding this comment.
The EIP mentioned that a few more instructions are affected: CALL, CALLCODE, STATICCALL, DELEGATECALL
so a quick question, do we need any modifications in those opcodes?
There was a problem hiding this comment.
I am almost 100% sure that this is okay though :)
There was a problem hiding this comment.
The change only affected the "code reading" ops, but the executing ones (CALL, CALLCODE...) remains the same as before. So they are still affected by 7702 itself, but not by this new change.
Co-authored-by: Lukasz Rozmej <[email protected]>
DO NOT MERGE!
Mekong does not include devnet 5 changes, so we cannot merge to master for now.
All EXTCODE ops now only reads the first two bytes of the delegation header, instead of reading from delegation target.
Changes described here:
https://github.com/ethereum/EIPs/pull/8969/files