7746 inital changes for confirmation #7758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @obasekiosa/ @LukaszRozmej , can you confirm if these changes look good for the issue. |
|
I am not sure if we should update one path based on another or handle it deeper when resolving the path. @rubo ? Also you accidentally updated submodule. |
|
Yes, i will fix the submodule changes. |
rubo
requested changes
Nov 18, 2024
| IKeyStoreConfig keyStoreConfig = _api.Config<IKeyStoreConfig>(); | ||
|
|
||
| // updating jwt-secret path based on data directory. | ||
| jsonRpcConfig.JwtSecretFile = String.Concat(keyStoreConfig.KeyStoreDirectory,"/jwt-secret"); |
There was a problem hiding this comment.
This change actually introduces another bug disrespecting the JsonRpc.JwtSecretFile setting. I think we should remove the default value of the IJsonRpcConfig.JwtSecretFile and check for null. If null, then apply this change.
|
Creating a new PR for the suggested changes as I wasn't able to undo the submodule changes - #7765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7746
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.