-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Single Pluggable DI Container #7630
Draft
asdacap
wants to merge
30
commits into
master
Choose a base branch
from
feature/single-pluggable-di-container
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled
andContainerModule
toINethermindPlugin
allowing plugins to extend components in a centralized manner.Enabled
property is needed as the runner need to know if it should include the plugin's module or not.IModule
enforces a convention where a plugin can use another plugin's configuration while only replacing some part of it, for example, the Optimism plugin uses the Merge plugin's module, replacing only thePoSSwitcher
to its own implementation.IConsensusPlugin
was removed, as plugin can replaceINethermidApi
via module.IInitializationPlugin
was removed, as plugin can provideIStep
via module andShouldRunStep
is basicallyEnabled
.IStep
is now resolved via dependency injection which allow its constructor to take on other component that need to run instead of justapi
.FallbackToFieldFromApi
which allows dependency injected components to take component fromINethermindApi
.OptimismPlugin
andMergePlugin
have largely the same code!.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.