-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Handle single pivot update + single peer; allow long non-finality #7611
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Ruben Buniatyan <[email protected]>
…nProcessor.cs Co-authored-by: Ruben Buniatyan <[email protected]>
I'm trying with a different approach - to use head block minus 64 instead of finalized block. It will not be 100% safe, but in e.g. optimism there is no other option, as there is no finalized hash in FCU until fully synced |
@marcindsobczak Sounds good! Let me test your approach with taiko. Wdyt about the second part of the pr that fixes the following?: when we have one peer and single fcu sent we can't start snapsync |
@flcl42 current aproach is not working with one peer? Why? |
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Need to sync as many nets as possible
Documentation
Requires documentation update
Requires explanation in Release Notes