Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pytest ci #205

Merged
merged 4 commits into from
Jan 24, 2025
Merged

feat: add pytest ci #205

merged 4 commits into from
Jan 24, 2025

Conversation

nmjustinchan
Copy link
Collaborator

No description provided.

cd ~/preconfirm-devnet-package
kurtosis run --enclave taiko-preconf-devnet . --args-file network_params.yaml

cd ~/Taiko-Preconf-AVS/e2e_tests
Copy link
Collaborator

@mskrzypkows mskrzypkows Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that better would be to run pytest in the github container, in this case we will use latest tests. Just .env need to be created to connect to proper L1 and L2 chains, what's more, in case of error we would have cleaner output in the github pipeline output. WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should do this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add it

@mskrzypkows mskrzypkows merged commit 287567e into master Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants