Jc/add docker build workflow #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskrzypkows
requested changes
Dec 5, 2024
| COPY ../Node/src /usr/src/taiko_preconf_avs_node/src | ||
| COPY ../Node/Cargo.toml /usr/src/taiko_preconf_avs_node/Cargo.toml | ||
| COPY ../Node/Cargo.lock /usr/src/taiko_preconf_avs_node/Cargo.lock | ||
| COPY ../Node /app/taiko_preconf_avs_node |
There was a problem hiding this comment.
Please, do not copy whole Node directory, as we build locally, the huge target directory is created inside and we don't want it to be copied into the docker image.
There was a problem hiding this comment.
This Dockerfile builds the node for you. You don't necessarily need to build locally. I have also add dockerignore file to ignore target dir.
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
Do we need a separate workflow for building images for PRs or can we use this one?
There was a problem hiding this comment.
You can manually trigger the actions to build the images.
mikhailUshakoff
approved these changes
Dec 31, 2024
mskrzypkows
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.