Allow injecting load balancer in addition to creating with reflection #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
commented
Sep 14, 2023
| @@ -63,7 +63,7 @@ public class DefaultClientChannelManager implements ClientChannelManager { | |||
|
|
|||
| public static final String METRIC_PREFIX = "connectionpool"; | |||
|
|
|||
| private final Resolver <? extends DiscoveryResult> dynamicServerResolver; | |||
There was a problem hiding this comment.
DiscoveryResult is a final class
jguerra
commented
Sep 14, 2023
| @@ -5,7 +5,7 @@ dependencies { | |||
| implementation libraries.guava | |||
| implementation libraries.slf4j | |||
|
|
|||
| implementation "com.netflix.ribbon:ribbon-loadbalancer:${versions_ribbon}" | |||
There was a problem hiding this comment.
had to change this because I added the constructor that takes a DynamicServerListLoadBalancer
gavinbunney
approved these changes
Sep 14, 2023
argha-c
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.