Remove nullish coalescing for textContent.
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default browser behavior when setting `.textContent` to `null` or `undefined` is to ultimately set the content to `''`†. This is quite different from the behavior of `createTextNode` though… by splitting the text node creation into multiple steps we can consistently leverage `.textContent` and remove the need to `?? ''`. † Note that the WHATWG spec only defines that behavior for `null`, but in practice all modern browsers seem to treat `undefined` similarly.
theengineear
commented
Nov 12, 2024
| @@ -60,6 +64,12 @@ it('renders an empty string in place of null value', () => { | |||
| assert(el.shadowRoot.getElementById('nul').textContent === ''); | |||
| }); | |||
|
|
|||
| it('renders an empty string in place of undefined value', () => { | |||
There was a problem hiding this comment.
Note that this passed before, we’re just specifically testing it now.
theengineear
commented
Nov 12, 2024
| @@ -1488,10 +1488,11 @@ class TemplateEngine { | |||
| } | |||
| const previousSibling = node.previousSibling; | |||
| if (previousSibling === startNode) { | |||
| const textNode = document.createTextNode(value ?? ''); | |||
There was a problem hiding this comment.
This was the only place we really needed to coalesce. If you pass null or undefined here you get 'null' or 'undefined'.
|
FYI @klebba — Hopefully this one is pretty easy to review. Shouldn’t be too controversial. |
|
@klebba — Gonna get this in to unblock myself on some other work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default browser behavior when setting
.textContenttonullorundefinedis to ultimately set the content to''†. This is quite different from the behavior ofcreateTextNodethough… by splitting the text node creation into multiple steps we can consistently leverage.textContentand remove the need to?? ''.† Note that the WHATWG spec only defines that behavior for
null, butin practice all modern browsers seem to treat
undefinedsimilarly.Here’s the spec for reference. This is related to #204.