include flowdir in syspath while loading file in Runner API #2182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
cwd
argument of the Runner is for selecting the directory under which thesubprocess
executes in..But, it doesn't play a role in loading of the flow file itself -- which is the first step of the lower level API to generate the command that will be executed via
subprocess
..aka loading of file --> generate command --> run via subprocess (
cwd
is only relevant here)Thus, in the directory structure like this:
if
training.py
hasfrom common import packages
and
test_sample.py
uses the Runner API as follows:the following issue is encountered:
This PR adds the
flow directory
intosys.path
and also removes it later...