Again

Netflix · Nov 19, 2024 · 603bd56 · 603bd56
1 parent f7d8543
commit 603bd56
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/metaflow/cli.py b/metaflow/cli.py
@@ -88,6 +88,9 @@ def echo_always(line, **kwargs):
         click.secho(ERASE_TO_EOL, **kwargs)
 
 
+echo = None
+
+
 def logger(body="", system_msg=False, head="", bad=False, timestamp=True, nl=True):
     if timestamp:
         if timestamp is True:

diff --git a/metaflow/cmd/develop/stub_generator.py b/metaflow/cmd/develop/stub_generator.py
@@ -1238,22 +1238,23 @@ def exploit_default(default_value: Any) -> Optional[str]:
                 buff.write(indentation + deco + "\n")
             buff.write(indentation + "def " + name + "(")
             kw_only_param = False
+            has_var_args = False
             for i, (par_name, parameter) in enumerate(my_sign.parameters.items()):
                 annotation = self._exploit_annotation(parameter.annotation)
 
                 default = exploit_default(parameter.default)
 
-                if kw_only_param and parameter.kind not in (
-                    inspect.Parameter.KEYWORD_ONLY,
-                    inspect.Parameter.VAR_KEYWORD,
-                ):
+                if kw_only_param and parameter.kind != inspect.Parameter.KEYWORD_ONLY:
                     raise RuntimeError(
                         "In function '%s': cannot have a positional parameter after a "
                         "keyword only parameter" % name
                     )
+                has_var_args |= parameter.kind == inspect.Parameter.VAR_KEYWORD
+
                 if (
                     parameter.kind == inspect.Parameter.KEYWORD_ONLY
                     and not kw_only_param
+                    and not has_var_args
                 ):
                     kw_only_param = True
                     buff.write("*, ")