Skip to content

Commit

Permalink
dont think its needed here, testing
Browse files Browse the repository at this point in the history
  • Loading branch information
RikishK committed Nov 20, 2024
1 parent c24d557 commit 57e2e42
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
15 changes: 8 additions & 7 deletions metaflow/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -504,13 +504,14 @@ def step(
default=None,
help="Tags for this instance of the step.",
)
@click.option(
"--aws-tags",
multiple=True,
default=None,
help="AWS tags.")
# @click.option(
# "--aws-tags",
# multiple=True,
# default=None,
# help="AWS tags.")
@click.pass_obj
def init(obj, run_id=None, task_id=None, tags=None, aws_tags=None, **kwargs):
# def init(obj, run_id=None, task_id=None, tags=None, aws_tags=None, **kwargs):
def init(obj, run_id=None, task_id=None, tags=None, **kwargs):
# init is a separate command instead of an option in 'step'
# since we need to capture user-specified parameters with
# @add_custom_parameters. Adding custom parameters to 'step'
Expand All @@ -520,7 +521,7 @@ def init(obj, run_id=None, task_id=None, tags=None, aws_tags=None, **kwargs):
# variables.

obj.metadata.add_sticky_tags(tags=tags)
obj.metadata.add_sticky_tags(tags=aws_tags)
# obj.metadata.add_sticky_tags(tags=aws_tags)

runtime = NativeRuntime(
obj.flow,
Expand Down
4 changes: 2 additions & 2 deletions metaflow/plugins/aws/step_functions/step_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -936,8 +936,8 @@ def _step_cli(self, node, paths, code_package_url, user_code_retries):
# Assign tags to run objects.
if self.tags:
params.extend("--tag %s" % tag for tag in self.tags)
if self.aws_tags:
params.extend("--aws-tags %s" % aws_tag for aws_tag in self.aws_tags)
# if self.aws_tags:
# params.extend("--aws-tags %s" % aws_tag for aws_tag in self.aws_tags)

# If the start step gets retried, we must be careful not to
# regenerate multiple parameters tasks. Hence, we check first if
Expand Down

0 comments on commit 57e2e42

Please sign in to comment.