Yingjianw/fix parent child empty null config #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevie9868
force-pushed
the
yingjianw/fixParentChildEmptyNullConfig
branch
3 times, most recently
from
a9d99d4 to
9756bf4
Compare
fix add test fix fix
stevie9868
force-pushed
the
yingjianw/fixParentChildEmptyNullConfig
branch
from
9756bf4 to
a79bb82
Compare
amboz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock clone table testing, fix a config bug in open source metacat. The current bug can cause a scenario, where we empty the config but the old config still remains due to the early return.
@gabeiglio I also decide to revert your PR for now as I want to separate the rollout, thanks!
I will put your PR back once we are ready for your PR for the rollout.