use TypeInfo to serialize to MetacatType instead of ObjectInspector #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevie9868
force-pushed
the
yingjianw/getCannonicalTypeUsingTypeInfoInsteadOfObjectInspector
branch
5 times, most recently
from
d2df4c6 to
481df53
Compare
stevie9868
force-pushed
the
yingjianw/getCannonicalTypeUsingTypeInfoInsteadOfObjectInspector
branch
from
481df53 to
16657c4
Compare
insyncoss
approved these changes
Apr 16, 2024
stevie9868
added a commit
that referenced
this pull request
May 1, 2024
…585) Co-authored-by: Yingjian Wu <[email protected]>
stevie9868
added a commit
that referenced
this pull request
May 1, 2024
…585) Co-authored-by: Yingjian Wu <[email protected]>
stevie9868
added a commit
that referenced
this pull request
May 13, 2024
…585) (#592) Co-authored-by: Yingjian Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for both hive and iceberg table, we use Hive ObjectInspector when serializing the schema into Metacat type but Hive ObjectInspector will internally lowercase every fieldNames, which breaks the fidelity of the fieldName.
Even though hive ObjectInspector contains fieldName and fieldType information, it's core purpose is to inspect the actual data of a hive field, which is not needed for schema description.
And instead we can just simply serialize schema directly using the Hive TypeInfo, which also contains the information such as field name and field type. And one advantage of using TypeInfo is that it preserves the fidelity of the fieldName.