Skip to content

Commit

Permalink
add more
Browse files Browse the repository at this point in the history
  • Loading branch information
Yingjian Wu committed Jul 6, 2024
1 parent 300947a commit d38b293
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -604,10 +604,10 @@ class ParentChildRelMetadataServiceSpec extends Specification{
where:
maxAllow | defaultMaxAllowPerRelStr | maxAllowPerDBPerRelTypeStr | maxAllowPerTablePerRelTypeStr | expectedChildAllowCount
3 | "" | "" | "" | 3
3 | "Other,5" | "CLONE,other,2" | "CLONE,testhive/test/other,2" | 3
3 | "Other,5" | "Other,other,2" | "Other,testhive/test/other,2" | 3
1 | "CLONE,5" | "" | "" | 5
1 | "CLONE,5;Other,3" | "" | "" | 5
1 | "CLONE,5;Other,3" | "CLONE,other,2" | "CLONE,testhive/test/other,2" | 5
1 | "CLONE,5;Other,3" | "Other,other,2" | "Other,testhive/test/other,2" | 5
1 | "CLONE,5" | "CLONE,test,3" | "" | 3
1 | "CLONE,5;Other,3" | "CLONE,test,3;CLONE,other,2"| "" | 3
1 | "CLONE,5;Other,3" | "CLONE,test,3;OTHER,other,2"| "CLONE,testhive/test/other,2" | 3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,6 @@ private void validateMaxAllow(final QualifiedName parentName,
maxAllow = props.getMaxAllow();
}

// if (parentName.toString().equals("testhive/testmaxallow/parent")) {
// final String errorMsg = String.format(
// "Parent table: %s allow to have %s child table",
// parentName, maxAllow);
// throw new ParentChildRelServiceException(errorMsg);
// }

// if maxAllow < 0, this means we can create as many child table under the parent
if (maxAllow < 0) {
return;
Expand Down

0 comments on commit d38b293

Please sign in to comment.