fix code

Netflix · Mar 8, 2024 · d1f3036 · d1f3036
1 parent 33fe167
commit d1f3036
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...ctional-tests/src/functionalTest/groovy/com/netflix/metacat/MySqlLookupServiceSpec.groovy b/...ctional-tests/src/functionalTest/groovy/com/netflix/metacat/MySqlLookupServiceSpec.groovy
@@ -25,7 +25,7 @@ import org.springframework.jdbc.datasource.DriverManagerDataSource
 import spock.lang.Shared
 import spock.lang.Specification
 
-class MySqlLookupServiceUnitTest extends Specification{
+class MySqlLookupServiceSpec extends Specification{
     private MySqlLookupService mySqlLookupService;
     private JdbcTemplate jdbcTemplate;
 

diff --git a/...t-metadata-mysql/src/main/java/com/netflix/metacat/metadata/mysql/MySqlLookupService.java b/...t-metadata-mysql/src/main/java/com/netflix/metacat/metadata/mysql/MySqlLookupService.java
@@ -33,6 +33,7 @@
 import java.sql.Statement;
 import java.sql.Types;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -205,7 +206,6 @@ private Lookup findOrCreateLookupByName(final String name, final boolean include
             lookup = new Lookup();
             lookup.setName(name);
             lookup.setId(lookupId);
-            lookup.setValues(Collections.EMPTY_SET);
         }
         return lookup;
     }
@@ -225,7 +225,11 @@ public Lookup addValues(final String name, final Set<String> values, final boole
                 insertLookupValuesIfNotExist(lookup.getId(), values);
             }
             if (includeValues) {
-                lookup.getValues().addAll(values);
+                if (lookup.getValues() == null || lookup.getValues().isEmpty()) {
+                    lookup.setValues(values);
+                } else {
+                    lookup.getValues().addAll(values);
+                }
             }
             return lookup;
         } catch (Exception e) {