address comments

Netflix · Jan 5, 2024 · b9692e0 · b9692e0
1 parent 1864797
commit b9692e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...ava/com/netflix/metacat/connector/polaris/PolarisConnectorTableServiceFunctionalTest.java b/...ava/com/netflix/metacat/connector/polaris/PolarisConnectorTableServiceFunctionalTest.java
@@ -8,6 +8,7 @@
 import com.netflix.metacat.common.dto.SortOrder;
 import com.netflix.metacat.common.server.connectors.model.TableInfo;
 import com.netflix.metacat.connector.polaris.configs.PolarisPersistenceConfig;
+import lombok.extern.slf4j.Slf4j;
 import org.junit.Assert;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -24,6 +25,7 @@
  * Some of the tests cannot be run in unit test as it uses h2 database, which does not support all
  * functionalities in crdb so include those tests here.
  */
+@Slf4j
 @ExtendWith(SpringExtension.class)
 @SpringBootTest(classes = {PolarisPersistenceConfig.class})
 @ActiveProfiles(profiles = {"polaris_functional_test"})
@@ -54,7 +56,7 @@ public void testList() {
             // pause execution for 10000 milliseconds (10 seconds)
             Thread.sleep(10000);
         } catch (InterruptedException e) {
-            System.out.println("Sleep was interrupted");
+            log.debug("Sleep was interrupted");
         }
 
         List<TableInfo> tables = this.getPolarisTableService().list(

diff --git a/...lTest/java/com/netflix/metacat/connector/polaris/PolarisStoreConnectorFunctionalTest.java b/...lTest/java/com/netflix/metacat/connector/polaris/PolarisStoreConnectorFunctionalTest.java
@@ -4,6 +4,7 @@
 import com.netflix.metacat.connector.polaris.configs.PolarisPersistenceConfig;
 import com.netflix.metacat.connector.polaris.store.PolarisStoreConnectorTest;
 import com.netflix.metacat.connector.polaris.store.entities.PolarisTableEntity;
+import lombok.extern.slf4j.Slf4j;
 import org.junit.Assert;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -17,6 +18,7 @@
 /**
  * Test persistence operations on Database objects.
  */
+@Slf4j
 @ExtendWith(SpringExtension.class)
 @SpringBootTest(classes = {PolarisPersistenceConfig.class})
 @ActiveProfiles(profiles = {"polaris_functional_test"})
@@ -36,7 +38,7 @@ public void testGetTableEntities() {
             // pause execution for 10000 milliseconds (10 seconds)
             Thread.sleep(10000);
         } catch (InterruptedException e) {
-            System.out.println("Sleep was interrupted");
+            log.debug("Sleep was interrupted");
         }
 
         // Test when db is empty
@@ -56,7 +58,7 @@ public void testGetTableEntities() {
             // pause execution for 10000 milliseconds (10 seconds)
             Thread.sleep(10000);
         } catch (InterruptedException e) {
-            System.out.println("Sleep was interrupted");
+            log.debug("Sleep was interrupted");
         }
 
         // Test pagination and sort