Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Allow JSON Documents with DateTime scalars to be deserialized to Objects #271

Merged

Conversation

richardcresswell
Copy link
Contributor

@richardcresswell richardcresswell commented Apr 15, 2021

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Allow the DgsQueryExecutor to deserialize JSON responses to Objects for documents containing scalar DateTime types.
Resolves #269

@paulbakker
Copy link
Collaborator

We have the same in GraphQLResponse in the graphql-dgs-client module, so it makes sense to support the same here.

@srinivasankavitha
Copy link
Contributor

srinivasankavitha commented Apr 15, 2021

Agree with @paulbakker. We actually also do the same thing in DgsSchemaProvider.kt as well. I wonder if we can use a common object mapper, at least within the same core module.

Edit: After some discussion, doesn't seem useful to share the object mapper since they are for different use cases.

@paulbakker paulbakker merged commit 19888de into Netflix:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: dgsQueryExecutor.executeAndExtractJsonPathAsObject cannot deserialize DateTime scalars
3 participants