Improve perf when writing MBTiles #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copying them in with AddRange Reduces unnecessary allocations and copies
|
|
FObermaier
approved these changes
Aug 5, 2024
FObermaier
added a commit
that referenced
this pull request
Aug 14, 2024
* Reset currentX and currentY when encoded data is not written * Add provided unit test slightly modified * Check extent of polygon's interior rings prior to encoding * Add extent test for lineal geometries * Fix failure case * Improve performance when writing MBTiles (#31) * Write encoded geometries directly to the destination list * If id is ulong use it directly * Reset currentX and currentY when encoded data is not written * Add provided unit test slightly modified * Check extent of polygon's interior rings prior to encoding * Add extent test for lineal geometries * Add min[Lineal|Polygonal]Extent to MapBoxTileWriter * Add ExtentInPixels to TileGeometryTransform * Add HasValidExtent functions to EncodeTo functions for lineal and polygonal geometries * Expose default values for min[Lineal|Polygonal]Extent and idAttributeName * Add unit test for min[Lineal|Polygonal]Extent * Fix GitHub Actions criticism * Update README.md * Update frameworks * Update action versions closes #29 --------- Co-authored-by: Dave Leaver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an internal application where writing MBTiles is the performance bottleneck, making these changes gave us some meaningful improvements.
Instead of having each Encode method return a new list (or yielding results) and then adding them to the Geometry using AddRange, pass in the Geometry list and add the contents directly.
This gives us a ~12% performance increase in our internal testing.
If id is a ulong, set it directly instead of ToString and Parse it. Another small performance improvement.