QQBar: construct from any Integer or Complex value #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... not just Int, Complex{Int}.
While at it, allow `QQBar(x::Any)` for any input `x` -- just forward
this to `QQBarFieldElem` and let that decide which conversions are
possible. That avoid situations where `QQBarFieldElem(x)` works but
`QQBar(x)` does not.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
- Coverage 84.70% 84.68% -0.02%
==========================================
Files 94 94
Lines 37460 37455 -5
==========================================
- Hits 31730 31719 -11
- Misses 5730 5736 +6 ☔ View full report in Codecov by Sentry. |
lgoettgens
approved these changes
Apr 4, 2024
lgoettgens
added a commit
that referenced
this pull request
Apr 19, 2024
This reverts commit 817ebfd.
lgoettgens
added a commit
that referenced
this pull request
Apr 19, 2024
lgoettgens
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... not just Int, Complex{Int}.
While at it, allow
QQBar(x::Any)for any inputx-- just forward this toQQBarFieldElemand let that decide which conversions are possible. That avoid situations whereQQBarFieldElem(x)works butQQBar(x)does not.This resolves on of my comments on issue #1650