This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Support downloading skylinks with paths and query params #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mrcnski
force-pushed
the
download-paths
branch
from
da14ad1 to
681e633
Compare
mrcnski
commented
Sep 10, 2020
mrcnski
commented
Sep 10, 2020
5 tasks
|
@kwypchlo Pls review |
kwypchlo
suggested changes
Oct 20, 2020
mrcnski
force-pushed
the
download-paths
branch
from
28d9b81 to
bb67f92
Compare
kwypchlo
suggested changes
Oct 23, 2020
mrcnski
force-pushed
the
download-paths
branch
from
baecfd1 to
a691e01
Compare
|
Ready for another review @kwypchlo. I still need to add tests for getting the subdomain skylink from getSkylinkUrl, I'll do that if everything else looks good. |
kwypchlo
suggested changes
Nov 18, 2020
There was a problem hiding this comment.
all tests that have it.each should have %s in their name that interpolates the input string so the tests have unique names, otherwise we end up with 300 tests with the same name on each of such case
it.each(invalidCases)("should return null on invalid case %s", (fullSkylink) => {
kwypchlo
approved these changes
Nov 18, 2020
This was referenced Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NebulousLabs/skynet-docs#34.