This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
[WIP] Single download by uid endpoint #3163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
reviewed
Jul 13, 2018
siatest/renter/renter_test.go
Outdated
| // {"TestRemoteRepair", testRemoteRepair}, | ||
| // {"TestSingleFileGet", testSingleFileGet}, | ||
| // {"TestStreamingCache", testStreamingCache}, | ||
| // {"TestUploadDownload", testUploadDownload}, |
There was a problem hiding this comment.
Getting the tests to pass by commenting out the test. Smart.
ChrisSchinnerl
force-pushed
the
single-download-endpoint
branch
from
c954677 to
b92f28f
Compare
ChrisSchinnerl
force-pushed
the
single-download-endpoint
branch
from
b92f28f to
a8b19d5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a uid to the download struct which can be used to uniquely identify and retrieve a download within the download history. It also adds an endpoint for retrieving a single download by its UID.
What I'm not sure about yet is how to provide the user with a UID when a download is initialized. It's easy for async downloads but blocking downloads and streams can't easily return the UID.
We might also want to find a more efficient way to retrieve a specific download info than looping over the whole history every time. Maybe a
DownloadHistorywrapper struct with methods likeAdd,Delete,Viewetc. would be sufficient that combines a map and slice and keeps them synced.Resolves #3146