Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Siac renter download rolling transfer speed and better units #3162

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Siac renter download rolling transfer speed and better units #3162

wants to merge 4 commits into from

Conversation

ChrisSchinnerl
Copy link
Contributor

@ChrisSchinnerl ChrisSchinnerl commented Jul 13, 2018 •
edited
Loading

Resolves #3148
Resolves #3147

demo

@ChrisSchinnerl ChrisSchinnerl changed the title Siac renter download rolling transfer speed Siac renter download rolling transfer speed and better units Jul 13, 2018
@ChrisSchinnerl
Copy link
Contributor Author

Theoretically a Ybps is 2^80 bps which is too large for the uint64 of bandwidthUnit but you can never be future proof enough :P

@ChrisSchinnerl
Copy link
Contributor Author

Something that still bothers me is the way we update the progress of the download. We only update it whenever a chunk is complete instead of when a piece is complete. That means that downloading a 40MB file will be stuck at 0% until the chunk is downloaded an then go right to 100%.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukechampine lukechampine Awaiting requested review from lukechampine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChrisSchinnerl